583464 - HeadsUpDisplay.clearConsoleOutput() fails

Status: RESOLVED FIXED

(DevTools :: General, defect)

Description

[Mihai Sucan [:msucan]]

Currently the WebConsole has three ways for clearing the output:

HUDService.clearDisplay(id)
JSTerm.clearOutput()
HeadsUpDisplay.clearConsoleOutput() - this is never used and it fails.

I bumped into this issue when writing a test code. I had the HeadsUpDisplay object and I wanted to call clearConsoleOutput(), but that failed. Then I saw the rest of the available methods that do the same thing.

We should probably fix the clearConsoleOutput() method or remove it.

Comment 1

[Mihai Sucan [:msucan]]

Attachment: fix + test code

Proposed fix and test code. This patch should apply cleanly on mozilla-central.

The fix is only limited to the HeadsUpDisplay.clearConsoleOutput() method.

Comment 2

[David Dahl :ddahl]

perhaps we only need 2 methods, the jsterm and the working hudservice one?

Comment 3

[Mihai Sucan [:msucan]]

Sure, we can go for that. Shall I post a patch that removes the HeadsUpDisplay.clearConsoleOutput() method? (marking the current patch as obsolete, obviously)

Comment 4

[David Dahl :ddahl]

(In reply to comment #3)
> Sure, we can go for that. Shall I post a patch that removes the
> HeadsUpDisplay.clearConsoleOutput() method? (marking the current patch as
> obsolete, obviously)

Yeah, less code is good. Make sure no other callers exist.

Comment 5

[Mihai Sucan [:msucan]]

Attachment: [checked-in] patch for removing the method

Updated patch - removed the method. It is unused, so no other changes are needed.

Comment 6

[Kevin Dangoor]

We can put this up for review, since it's just a trivial removal of code.

Comment 7

[Shawn Wilsher :sdwilsh]

Comment on attachment 462123 [details] [diff] [review]
[checked-in] patch for removing the method

r=sdwilsh

Comment 8

[Shawn Wilsher :sdwilsh]

Comment on attachment 462123 [details] [diff] [review]
[checked-in] patch for removing the method

While I'm here, a=sdwilsh with a simple, only code removal, change.

Comment 9

[Rob Campbell [:rc] (:robcee)]

Comment on attachment 462123 [details] [diff] [review]
[checked-in] patch for removing the method

http://hg.mozilla.org/mozilla-central/rev/111eb6a4ad98