583531 - Suppressing SSL/cert errors is too complicated

Status: RESOLVED WORKSFORME

(Core :: Security: PSM, defect)

Description

[:Gavin Sharp [email: [e-mail]]]

Problem: simply suppressing SSL/cert error messages requires implementing two separate interfaces (nsIBadCertListener2 and nsISSLErrorListener) and adding the relevant object as a notificationCallback on the channel. We do this in several places, and two helper utils have been added to make it easier (CertUtils.jsm and nsBadCertHandler.js), but it's still a hassle (especially for C++ code where instantiating an nsBadCertHandler may not be desirable, e.g. nsPrefetchService for bug 463117).

Proposed solution: 
It would be easier if it was as simple as adding a load flag to the channel.
1) add nsIRequest::LOAD_IGNORE_SSL_ERRORS loadFlag
2) add "suppressErrorMessages" attribute to nsISSLSocketControl
3) set suppressErrorMessages to (loadFlags & LOAD_IGNORE_SSL_ERRORS) in nsSocketTransport::BuildSocket (not sure exactly how to propagate from the channel)
4) have nsNSSBadCertHandler/nsHandleSSLError suppress the error accordingly

bz/biesi/jduell: is 1) feasible? any tips for 3)?

kaie: does 2)-4) sound good?

Comment 1

[Kai Engert (:KaiE:)]

2-4 sounds good to me, as long as you still abort the channel on any cert errors not overridden.

Comment 2

[:Gavin Sharp [email: [e-mail]]]

Yeah, I don't intend to change any of the behavior re: failing on errors.

Comment 3

[Brian Smith (:briansmith, :bsmith, use NEEDINFO?)]

Fixed by bug 682329. Now, you don't have to do anything to suppress dialog boxes. Instead, you must implement the UI yourself, if you want UI.