warning: ‘const char* GetMIMEType(nsIPluginInstance*)’ defined but not used in nsObjectFrame.cpp

RESOLVED FIXED in mozilla6

Status

()

Core
Layout
RESOLVED FIXED
7 years ago
6 years ago

People

(Reporter: jdm, Assigned: dholbert)

Tracking

Trunk
mozilla6
x86
Linux
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [build_warning])

Attachments

(1 attachment, 1 obsolete attachment)

Comment hidden (empty)
(Reporter)

Updated

7 years ago
Whiteboard: [build_warning]
There are now 3 "defined but not used [on linux]" warnings for this file:
> layout/generic/nsObjectFrame.cpp:1975: warning: 'void DrawPlugin(mozilla::layers::ImageContainer*, void*)' defined but not used
> layout/generic/nsObjectFrame.cpp:1983: warning: 'void OnDestroyImage(void*)' defined but not used
> layout/generic/nsObjectFrame.cpp:2787: warning: 'const char* GetMIMEType(nsIPluginInstance*)' defined but not used

These functions are only called in #ifdef XP_MACOSX blocks, so the function definitions themselves should be #ifdef XP_MACOSX.
Created attachment 527558 [details] [diff] [review]
fix

This should do it. Testing locally & on tryserver as a cross-platform sanity-check.
Assignee: nobody → dholbert
Status: NEW → ASSIGNED
Created attachment 527643 [details] [diff] [review]
fix v2

Ah, tryserver told me that the previous patch had neglected to notice an #ifdef XP_WIN spot where "::GetMIMEType" is called.

This version tweaks the GetMIMEType ifdef to build if we're on XP_MACOSX or XP_WIN. This passed on TryServer.
Attachment #527558 - Attachment is obsolete: true
Attachment #527643 - Flags: review?(joshmoz)

Updated

6 years ago
Attachment #527643 - Flags: review?(joshmoz) → review+
http://hg.mozilla.org/mozilla-central/rev/29ea216a4153
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla6
You need to log in before you can comment on or make changes to this bug.