58363 - wrong TimeBombURL returned in nsBrowserContentHandler::GetDefaultArgs(...)

Status: VERIFIED FIXED

(SeaMonkey :: UI Design, defect, P3)

Description

[Peter "jag" Annema]

2403         if ( expired ) 
2404         {
2405             char* urlString;
2406             rv = timeBomb->GetTimebombURL(&urlString);
2407             if ( NS_FAILED(rv) ) return rv;
2408 
2409             *aDefaultArgs =  nsXPIDLString::Copy(url);
2410             nsMemory::Free(urlString);
2411             return rv;
2412         }

The urlString is never used. Tracing this code's history explains why. It used
to be something like:

nsString url(urlString);
*aDefaultArgs = url.ToNewUnicode();

This was simplified to

*aDefaultArgs =  NS_ConvertASCIItoUCS2(url).ToNewUnicode();

Note the bogus |url| instead of |urlString|. This always gets us an empty string
instead of the TimeBombURL.

This change to the code was probably made because there already was a |url|
(compiler warnings), and the compile didn't fail because |url| already existed.
Because the other |url| is |nsXPIDLCString url;|, it was changed to use
nsXPIDLString::Copy(...).

Suggested fix:

-             *aDefaultArgs =  nsXPIDLString::Copy(url);
+             *aDefaultArgs =  NS_ConvertASCIItoUCS2(urlString).ToNewUnicode();

I'll attach a patch.

Comment 1

[Peter "jag" Annema]

Adding keywords, changing summary slightly.

Comment 2

[Peter "jag" Annema]

Attachment: [patch] suggested fix

Comment 3

[Peter "jag" Annema]

Mass move to [e-mail]

Comment 4

[Peter Trudelle]

resolving as fixed per jag

Comment 5

[sairuh (rarely reading bugmail)]

rubberstamp vrfy (unless you have a testcase for me to check :).