583702 - comm-* tree closure hooks are running after pushlog hooks

Status: RESOLVED DUPLICATE of bug 573285

(mozilla.org Graveyard :: Server Operations, task)

Description

[Mark Banner (:standard8)]

We had an issue the other day, whereby trying to push to a closed tree broke the pushlog. I've just noticed in a push that I've just done:

pushing to ssh://hg.mozilla.org/comm-central/
searching for changes
remote: adding changesets
remote: adding manifests
remote: adding file changes
remote: added 1 changesets with 1 changes to 1 files
remote: Trying to insert into pushlog.
remote: Please do not interrupt...
remote: Inserted into the pushlog db sucessfully.
remote: Tree Thunderbird is CLOSED! (comm-central, http://tinderbox.mozilla.org/Thunderbird/)
remote: Add layout and directory xpts to Thunderbird's package manifest. No bug, blanket-rs=philor. Part of build tidy up before opening CLOSED TREE.
remote: But you included the magic words.  Hope you had permission!

So if I'm understanding this correctly, the tree closure hook for comm-central is running *after* the pushlog hook. This isn't good and could lead to the same bustage again.

Please ensure that treeclosure_comm_central.py is running after pushlog.py, on the following repositories:

comm-central
releases/comm-1.9.2
releases/comm-1.9.1

Thanks.