Closed Bug 583745 Opened 12 years ago Closed 12 years ago

When Navigation Toolbar is hidden, tabs look ugly with Bookmarks Toolbar.

Categories

(Firefox :: Theme, defect)

Product:
Firefox
Component:
Theme
Platform:
x86
Windows XP
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 4.0b4

People

(Reporter: naga_maga, Assigned: dao)

Details

Attachments

(4 files)

this is how it looks with navigation toolbar
17.20 KB, image/png
Details
and without navigation toolbar
13.80 KB, image/png
Details
patch
1.23 KB, patch
asaf
: review+
Gavin
: approval2.0+
Details | Diff | Splinter Review
tab bar with toolbar created by some addon
11.77 KB, image/png
Details 
User-Agent:       Mozilla/5.0 (Windows; Windows NT 5.1; rv:2.0b3pre) Gecko/20100802 Minefield/4.0b3pre ( .NET CLR 3.5.30729)
Build Identifier: Mozilla/5.0 (Windows; Windows NT 5.1; rv:2.0b3pre) Gecko/20100802 Minefield/4.0b3pre ( .NET CLR 3.5.30729)

Bookmarks Toolbar should change its background (to this gradient which the Nav. Toolbar has) when Navigation Toolbar is hidden.

Reproducible: Always

Steps to Reproduce:
1. Open Bookmarks Toolbar.
2. Hide the Navigation Toolbar.
Version: unspecified → Trunk
Severity: trivial → normal
Assignee: nobody → dao
Status: UNCONFIRMED → NEW
Ever confirmed: true
Attached patch patch — — Splinter Review 
selectors borrowed from pinstripe
Attachment #464620 - Flags: review?(mano)
Comment on attachment 464620 [details] [diff] [review]
patch

r=mano
Attachment #464620 - Flags: review?(mano) → review+
Attachment #464620 - Flags: approval2.0?
Attachment #464620 - Flags: approval2.0? → approval2.0+
http://hg.mozilla.org/mozilla-central/rev/592937ef9b4d
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 4.0b4
it still looks bad with toolbars created by addons (in this case "f-secure browsing protection toolbar" if it makes difference)
(In reply to comment #6)
> Created attachment 465251 [details]
> tab bar with toolbar created by some addon
> 
> it still looks bad with toolbars created by addons (in this case "f-secure
> browsing protection toolbar" if it makes difference)

Could you please file a new bug? Thanks.
So... I filed bug 586663 few weeks ago. Check this out! :)
You need to log in before you can comment on or make changes to this bug.