583749 - If menu bar is shown the bookmarks button shouldn't appear when customizing the toolbar

Status: RESOLVED DUPLICATE of bug 581238

(Toolkit :: Toolbars and Toolbar Customization, defect)

Description

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Mozilla/5.0 (Windows; Windows NT 6.1; rv:2.0b2) Gecko/20100720 Firefox/4.0b2

When the menu bar is shown, there is no bookmarks button in the navigation toolbar. Nevertheless, when you customize the toolbars the button is displayed at the end of the navigation toolbar. To lesser the confusion for users we should hide the button, if it is not part of the current toolbars.

Steps:
1. Create a fresh profile
2. Make the menu visible
3. Customize your toolbar

Comment 1

[Michael Lefevre]

However, as noted in bug 586647, it is only the nav toolbar where it disappears. If you customise it onto a different bar, then it is not hidden.

So there isn't really a concept of "not part of the current toolbars" - whether it shows depends on where it is positioned, as well as which toolbars are showing.

Comment 2

[Marco Bonardo [:mak]]

I'm going to dupe since there is no need for multiple bugs on the button doing crazy things in customize mode, one is fine to handle "customize".