Closed
Bug 58378
Opened 24 years ago
Closed 24 years ago
appfilelocprovider x2
Categories
(SeaMonkey :: UI Design, defect, P3)
SeaMonkey
UI Design
Tracking
(Not tracked)
VERIFIED
FIXED
People
(Reporter: BenB, Assigned: ccarlen)
Details
We have 2 inconsistent copies of appfilelocprovider in the source tree - one in modules and one in xpfe. Both checked in by <conrad%ingress.com>, same minute. conrad, what's up there???
Reporter | ||
Comment 1•24 years ago
|
||
We need a "this-is-a-mess" keyword ;-P. brendan, who owns mozilla/modules/? You?
Keywords: mozilla1.0
Comment 2•24 years ago
|
||
Conrad, what's the plan? /be
Assignee | ||
Comment 4•24 years ago
|
||
I'll get rid of the one in xpfe. What sort of r=, a= do I need to remove files? They're not used by anything.
Status: NEW → ASSIGNED
Comment 5•24 years ago
|
||
Removal should get a single level of review by cls. If that! Sometimes one finds the Mac build still uses an old file, too -- Conrad, are you Mac enabled? /be
Assignee | ||
Comment 6•24 years ago
|
||
Yeah, I'm Mac-enabled. I made sure a while back that no makefiles referenced this dir. After deleting it locally, I'll do clobber builds just to make sure.
It looks like we're still using the modules/ version on the mac instead o fthe xpfe version according to build/mac/NGLayoutBuildList.pm.
Reporter | ||
Comment 8•24 years ago
|
||
cls: ? Conrad said: "I'll get rid of the one in xpfe."
Assignee | ||
Comment 9•24 years ago
|
||
Chris, we ARE using the one in /modules. In addition to build/mac/NGLayoutBuildList.pm, check out allmakefiles.sh, mozilla/Makefile.in, and mozilla/makefile.win.
Comment 10•24 years ago
|
||
Sorry, I got myself confused and somehow thought I was looking at modules related makefiles when I was looking at xpfe related makefiles. Don't mind me. Carry on, carry on. :)
Assignee | ||
Comment 11•24 years ago
|
||
Chris, then can I get your r= on yanking this stuff? In addition to looking at the makefiles and mac build scripts, I did clobber builds on Win & Linux after yanking it locally and it was OK.
Comment 12•24 years ago
|
||
r=cls
Assignee | ||
Comment 13•24 years ago
|
||
Files in xpfe/appfilelocprovider were removed.
Status: ASSIGNED → RESOLVED
Closed: 24 years ago
Resolution: --- → FIXED
Reporter | ||
Comment 15•24 years ago
|
||
lxr does not show the dir. The bonsai log for src/nsAppFileLocationProvider.cpp (or similar) (in Attic) in xpfe shows that the updates to that file were a subset of the updates to the copy in modules. So, the remaining copy has all the fixes. Agree VERIFIED.
Updated•20 years ago
|
Product: Core → Mozilla Application Suite
You need to log in
before you can comment on or make changes to this bug.
Description
•