Closed Bug 58378 Opened 24 years ago Closed 24 years ago

appfilelocprovider x2

Categories

(SeaMonkey :: UI Design, defect, P3)

defect

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: BenB, Assigned: ccarlen)

Details

We have 2 inconsistent copies of appfilelocprovider in the source tree - one in
modules and one in xpfe. Both checked in by <conrad%ingress.com>, same minute.
conrad, what's up there???
We need a "this-is-a-mess" keyword ;-P.

brendan, who owns mozilla/modules/? You?
Keywords: mozilla1.0
Conrad, what's the plan?

/be
over to his ns addr. conrad?
Assignee: conrad → ccarlen
I'll get rid of the one in xpfe. What sort of r=, a= do I need to remove files?
They're not used by anything.
Status: NEW → ASSIGNED
Removal should get a single level of review by cls.  If that!  Sometimes one
finds the Mac build still uses an old file, too -- Conrad, are you Mac enabled?

/be
Yeah, I'm Mac-enabled. I made sure a while back that no makefiles referenced
this dir. After deleting it locally, I'll do clobber builds just to make sure.
It looks like we're still using the modules/ version on the mac instead o fthe
xpfe version according to build/mac/NGLayoutBuildList.pm.
cls: ? Conrad said: "I'll get rid of the one in xpfe."
Chris, we ARE using the one in /modules. In addition to
build/mac/NGLayoutBuildList.pm, check out allmakefiles.sh, mozilla/Makefile.in,
and mozilla/makefile.win.
Sorry, I got myself confused and somehow thought I was looking at modules
related makefiles when I was looking at xpfe related makefiles.  Don't mind me.
Carry on, carry on. :)
Chris, then can I get your r= on yanking this stuff? In addition to looking at
the makefiles and mac build scripts, I did clobber builds on Win & Linux after
yanking it locally and it was OK.
r=cls
Files in xpfe/appfilelocprovider were removed.
Status: ASSIGNED → RESOLVED
Closed: 24 years ago
Resolution: --- → FIXED
rubberstamp vrfy.
Status: RESOLVED → VERIFIED
lxr does not show the dir.
The bonsai log for src/nsAppFileLocationProvider.cpp (or similar) (in Attic) in
xpfe shows that the updates to that file were a subset of the updates to the
copy in modules. So, the remaining copy has all the fixes.
Agree VERIFIED.
Product: Core → Mozilla Application Suite
You need to log in before you can comment on or make changes to this bug.