Web Console 'Clear Filter' button is not keyboard accessible

RESOLVED FIXED

Status

()

Firefox
Developer Tools
RESOLVED FIXED
8 years ago
8 years ago

People

(Reporter: Neil Deakin, Assigned: Neil Deakin)

Tracking

({access})

unspecified
access
Points:
---

Firefox Tracking Flags

(blocking2.0 beta5+)

Details

(Whiteboard: [kd4b4])

Attachments

(1 attachment)

(Assignee)

Description

8 years ago
This bug has two ways to find it:

Method 1:

1. Be asked to do a review a bug on the Web Console
2. While looking at the code, come across some existing code in a function called 'setFilterTextBoxEvents' which makes a button respond to the 'click' event rather than correctly using the 'command' event.
3. Slap the original developer.

Method 2:

1. Open Tools -> Web Console
2. Enter some filter text
3. Tab to the Clear Filter button
4. Press Space

Expected:
 The filter text to be cleared

Actual:
  Nothing happens

The workaround is to just focus the filter text field and press delete, which makes one wonder why the clear filter button is there in the first place.

Comment 1

8 years ago
(In reply to comment #0)
> This bug has two ways to find it:
> 
> Method 1:
> 
> 1. Be asked to do a review a bug on the Web Console
> 2. While looking at the code, come across some existing code in a function
> called 'setFilterTextBoxEvents' which makes a button respond to the 'click'
> event rather than correctly using the 'command' event.
> 3. Slap the original developer.


The original developer who was trained in the proper setting of xul events?

good luck finding him. 

In the meantime, maybe you can use this bug to actually help train the original developer? kthxbye
(Assignee)

Comment 2

8 years ago
Created attachment 462223 [details] [diff] [review]
fix

The training is simple. One just needs to replace 'click' with 'command'. The training is complete.

Anyway, all kidding aside, here is a patch.
Assignee: nobody → enndeakin
Status: NEW → ASSIGNED
Attachment #462223 - Flags: review?(ddahl)

Comment 3

8 years ago
Comment on attachment 462223 [details] [diff] [review]
fix

Cool, thanks. If you can r+ this patch, i think it could then be checked in. Cheers!
Attachment #462223 - Flags: review?(ddahl)

Updated

8 years ago
Attachment #462223 - Flags: review?(enndeakin)
(Assignee)

Comment 4

8 years ago
Er, I wrote the patch, so I shouldn't review it.

Updated

8 years ago
Attachment #462223 - Flags: review?(enndeakin) → review?(dtownsend)
Attachment #462223 - Flags: review?(dtownsend) → review+
(Assignee)

Updated

8 years ago
Attachment #462223 - Flags: approval2.0?

Updated

8 years ago
Whiteboard: [kd4b4]

Updated

8 years ago
blocking2.0: --- → beta5+
Whiteboard: [kd4b4] → [kd4b4][strings]

Updated

8 years ago
Whiteboard: [kd4b4][strings] → [kd4b4]

Updated

8 years ago
Attachment #462223 - Flags: approval2.0?
(Assignee)

Comment 5

8 years ago
OK, so this was actually handled by bug 582121, so this is not needed anymore.
Status: ASSIGNED → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.