Closed Bug 583839 Opened 12 years ago Closed 12 years ago

[FIXr]Quickstub string handling shouldn't addref/release the string buffer from traceable natives

Categories

(Core :: XPConnect, defect, P1)

x86
macOS
defect

Tracking

()

RESOLVED FIXED
mozilla2.0b4

People

(Reporter: bzbarsky, Assigned: bzbarsky)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Attached patch Like soSplinter Review
Like bug 577472, but for the other codepath.
Attachment #462159 - Flags: review?(Olli.Pettay)
Attachment #462159 - Flags: review?(Olli.Pettay) → review+
Comment on attachment 462159 [details] [diff] [review]
Like so

This is a simple safe patch; speeds up getAttribute on trace by 15% or so (as well as any other quickstubbed DOM method that returns a string).
Attachment #462159 - Flags: approval2.0?
Attachment #462159 - Flags: approval2.0? → approval2.0+
Summary: Quickstub string handling shouldn't addref/release the string buffer from traceable natives → [FIXr]Quickstub string handling shouldn't addref/release the string buffer from traceable natives
Priority: -- → P1
Pushed http://hg.mozilla.org/mozilla-central/rev/653c26de2570
Status: NEW → RESOLVED
Closed: 12 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → mozilla2.0b4
You need to log in before you can comment on or make changes to this bug.