Closed
Bug 583839
Opened 14 years ago
Closed 14 years ago
[FIXr]Quickstub string handling shouldn't addref/release the string buffer from traceable natives
Categories
(Core :: XPConnect, defect, P1)
Tracking
()
RESOLVED
FIXED
mozilla2.0b4
People
(Reporter: bzbarsky, Assigned: bzbarsky)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
|
2.57 KB,
patch
|
jst
:
review+
jst
:
approval2.0+
|
Details | Diff | Splinter Review |
Like bug 577472, but for the other codepath.
Attachment #462159 -
Flags: review?(Olli.Pettay)
|
||
Updated•14 years ago
|
Attachment #462159 -
Flags: review?(Olli.Pettay) → review+
|
Assignee | |
Comment 1•14 years ago
|
||
Comment on attachment 462159 [details] [diff] [review] Like so This is a simple safe patch; speeds up getAttribute on trace by 15% or so (as well as any other quickstubbed DOM method that returns a string).
Attachment #462159 -
Flags: approval2.0?
|
|
||
Updated•14 years ago
|
Attachment #462159 -
Flags: approval2.0? → approval2.0+
|
|
Assignee | |
Updated•14 years ago
|
Summary: Quickstub string handling shouldn't addref/release the string buffer from traceable natives → [FIXr]Quickstub string handling shouldn't addref/release the string buffer from traceable natives
|
|
Assignee | |
Updated•14 years ago
|
Priority: -- → P1
|
|
Assignee | |
Comment 2•14 years ago
|
||
Pushed http://hg.mozilla.org/mozilla-central/rev/653c26de2570
Status: NEW → RESOLVED
Closed: 14 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → mozilla2.0b4
You need to log in
before you can comment on or make changes to this bug.
Description
•