"Your comment contains swear words (porn). In order to help us improve our products, please use words that help us create an action or to-do from your constructive feedback. Thanks!" Porn is not a swear word or a term of anger. Forcing commenters use less common terms, such as "adult" or "pron" or "xxx", just makes it harder for me to search and find out what issues porn surfers hit.
I agree that's a term we can and probably should remove. Whacha say, Aakash? Jesse: I hope I am not being ridiculous: Do you want to go through the list and give me a diff of items you want removed? The file is here: http://github.com/fwenzel/reporter/blob/master/lib/swearwords/badwords.txt
There are a few variants of porn in there, such as "p0rn" and "pr0n" and "xxx". And many terms that are related to sex but not anger and so probably don't need to be in the list.
You have a very valid point there. Since we only use this to encourage useful feedback, we should probably remove all words that aren't related to anger. Assigning to Aakash, can you clean the list in that respect? It will probably bring it down to a very limited amount of entries, which is a good thing. Also, it'll save localizers the challenge of coming up with every conceivable insult in their language (though that would be entertaining.).
Please maintain a separate sexwords.txt and angrywords.txt, which could be combined with yomommajokes.txt to make badwords.txt.
I guess this bug prevents us to get feedback from 80% of the web usage experience... ;-)
Here's an initial patch I wrote after comment #1... It'll need updating to remove all non-angry sex words, as per comment #3, though. http://github.com/reedloden/reporter/commit/03c1be39c2c04d8e2d7ef3e67b98844015a0780c
This is funny and all, but I'd like to turn this around and ask Jesse what can users specifically offer in terms of constructive criticism with including "porn"? Also, I'd like to reiterate that the purpose of this tool is to offer users a way to offer us constructive criticism about our browser. So, What it is: - A way to allow users to comment on whether they like/dislike the new features of Firefox - A way to allow users to comment on broken websites - A way to allow users to comment on whether they like/dislike their experience in browsing websites in relation to previous experiences of Firefox What it is not: - A way to allow users to comment on what they browse - A way to allow users to spam or game our system - A way to allow users/triagers to find amusement in using this system I think the wording needs to change to better represent this sentiment, so I'll go ahead and do that. I'd also like an answer from Jesse before going forward on patches to this bug.
Quite honestly, it could be something as simple as "various porn sites won't play video" or "I like that I can visit porn sites privately." Context is helpful.
Here are some actual pieces of feedback where users typed alternate terms. Knowing that it's porn is useful as context. It lets people interested in improving the porn experience find out what problems users are hitting, and it lets triagers in office environments avoid offending their coworkers by accidentally following NSFW links. "I cant acces a lot of firefox's features through firefox button. Such as downloads, 'pron mode', addons manager etc." "Firefox has frozen and crashed repeatedly when having mutiple tabs open from popular adult sites open." "my adult rated videos uploaded and downloaded very quickly compared to the other browsers." "OMG i caught my son watching [adults things].. isn't there any ani-[adult things] or parenntal control??!!!?!!!!!!!?!!!!!!!!" "It seems it stops annoying popups on adult sites. Thx guys."
The bottom 4 messages you mention could have gone either way between "porn" and "adult" whether or not "porn" was blocked from submission. Also, even though "pron mode" (1st message) might be helpful with indicating how many users call it that instead of "private browsing", it's not entirely helpful to still allow "porn" instead of "pron". The real problem there is how to show "porn mode" in the same bucket as "private browsing". Jesse, let's talk about this tomorrow in the office. I'd like to talk about 1-2 ideas with you that might provide a solution that works for the both of us.
FWIW, I agree with the general notion of comment 0 and Dave's remarks as well. I am leaning towards applying reed's patch. If that goes far enough or if we need to make further changes is a different question.
Aye, after sleeping on it, Jesse's right. Fail on my part. So, Fred, let's go with the patch. I'll submit a patch with a smaller list later on today.
I cherry-picked reed's patch: http://github.com/fwenzel/reporter/commit/d40eb33
more larger-scale changes made here - http://github.com/sammybahamas/reporter/commit/d237b323bfd45b42070be635b4ced621d75f1926 Moving this to resolved fixed due to comment #13
Verified FIXED on http://input.stage.mozilla.com/en-US/happy and http://input.stage.mozilla.com/en-US/sad; note that I of course didn't test _every_ word, but enough random ones to see it working just fine.
I cherry-picked Aakash's commit now. (Why was this verified fixed before that?) Ah well.
(In reply to comment #16) > I cherry-picked Aakash's commit now. (Why was this verified fixed before that?) > Ah well. Because it was resolved fixed in comment 14? Again, I didn't check _every_ word; don't understand what you take issue with.
Thanks. The system works. http://twitter.com/pornzilla/status/21075869162