Closed
Bug 583966
Opened 14 years ago
Closed 10 years ago
Remove unnecessary "REQUIRES = dbm" from manifest.mn
Categories
(NSS :: Build, defect)
NSS
Build
Tracking
(Not tracked)
RESOLVED
FIXED
3.13
People
(Reporter: wtc, Assigned: wtc)
Details
Attachments
(1 file)
|
15.61 KB,
patch
|
christophe.ravel.bugs
:
review+
|
Details | Diff | Splinter Review |
The attached patch removes unnecessary "REQUIRES = dbm" lines from manifest.mn files. (The only directory that really requires dbm is mozilla/security/nss/lib/softoken/legacydb.) It also removes an unnecessary LIBSRCS variable in mozilla/security/nss/lib/cryptohi/manifest.mn. This MXR query shows LIBSRCS is only defined and used in that file: http://mxr.mozilla.org/security/search?string=LIBSRCS Note: the patch skips most manifest.mn files under mozilla/security/nss/cmd. I'll deal with those later if I have time.
Attachment #462319 -
Flags: review?(christophe.ravel.bugs)
|
||
Comment 1•14 years ago
|
||
Comment on attachment 462319 [details] [diff] [review] Proposed patch (checked in) r+ Christophe
Attachment #462319 -
Flags: review?(christophe.ravel.bugs) → review+
|
Assignee | |
Comment 2•14 years ago
|
||
Comment on attachment 462319 [details] [diff] [review] Proposed patch (checked in) I checked in this patch on the NSS trunk (NSS 3.13).
Attachment #462319 -
Attachment description: Proposed patch → Proposed patch (checked in)
|
||
Comment 3•10 years ago
|
||
https://hg.mozilla.org/projects/nss/rev/04e5acd9839b (The patch touched multiple files, so I won't bother giving bonsai.mozilla.org CVS links)
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•