584004 - tree closure hook is busted, let's disable and/or fix it

Status: RESOLVED DUPLICATE of bug 573285

(Developer Services :: Mercurial: hg.mozilla.org, defect)

Description

[Axel Hecht [:Pike]]

Right now, the tree closure hook ends up with a busted pushlog db whenever it's rejecting a push.

We should disable it, and then fix it, IMHO.

Comment 1

[Mark Banner (:standard8)]

If it is disabled for mozilla-central, please do the same for comm-central as well.

Comment 2

[Dirkjan Ochtman (:djc)]

Aravind is currently floating a patch for this on the Mercurial list. If that or some other solution is accepted into Mercurial (should happen within one or two days), I think we should just backport the accepted patch to what we're running.

Comment 3

[Aravind Gottipati [:aravind]]

This is not a case of tree closure hook being busted, but more of an artifact of the new mercurial not honoring hook ordering.  As djc said, I have a patch fix (proposal), will do something about this in the next couple of days.

If it turns out that my patch is useless, I have other plans of attach that involve hacking the pushlog hook itself, but those are ugly and I'd rather do this the right way.  I am tempted to dup this to bug 573285, but we may end up needing this bug, so I will leave it alone for now.