Closed
Bug 584006
Opened 14 years ago
Closed 14 years ago
Add-ons manager utilities button style needs to be correct on all platforms
Categories
(Toolkit :: Add-ons Manager, defect)
Toolkit
Add-ons Manager
Tracking
()
VERIFIED
FIXED
mozilla2.0b8
Tracking | Status | |
---|---|---|
blocking2.0 | --- | final+ |
People
(Reporter: tech4pwd, Assigned: Unfocused)
References
Details
Attachments
(3 files, 1 obsolete file)
2.57 KB,
patch
|
Unfocused
:
review+
|
Details | Diff | Splinter Review |
1.87 KB,
patch
|
Unfocused
:
review-
|
Details | Diff | Splinter Review |
868.09 KB,
image/png
|
Details |
User-Agent: Mozilla/5.0 (Windows; Windows NT 6.1; rv:2.0b3pre) Gecko/20100802 Minefield/4.0b3pre Build Identifier: Currently the new Update (dropdown) button seems out of place. It looks closer to being native to OSX than it does to looking like it belongs on Windows 7 or even Firefox, as such,the button should be the style of the new Firefox toolbar buttons. Reproducible: Always
Comment 1•14 years ago
|
||
That's what I have seen yesterday too. Its style doesn't match the one from the mockups: https://bug562622.bugzilla.mozilla.org/attachment.cgi?id=442478
Status: UNCONFIRMED → NEW
blocking2.0: --- → ?
Ever confirmed: true
OS: Windows 7 → All
Hardware: x86 → All
Version: unspecified → Trunk
Updated•14 years ago
|
Assignee: nobody → bmcbride
blocking2.0: ? → final+
Assignee | ||
Comment 2•14 years ago
|
||
Note that the style is just temporary, until the visual redesign - and I didn't spend a lot of time styling it because of that. Though the gear icon is very OSX-like. I think Boriss is still thinking through what icon should be used on other OSes.
Reporter | ||
Comment 3•14 years ago
|
||
The gear is fine. It's the shape of the button that is alien to the Windows environment.
Reporter | ||
Updated•14 years ago
|
Summary: Update button style should match that of the Firefox → Update button style should match that of Firefox
Comment 4•14 years ago
|
||
(In reply to comment #2) > Though the gear icon is very OSX-like. The gear is used for about everything on linux desktops... - "gtk-execute" icon - "System tools" category icon - KDE logo - ... The gear metaphor seems to suggest motion, doing any kind of "work", but it is not very specific. Does it have a strict meaning on OSX? I wonder if a simple text label would be a better choice her. (Btw, is there a bug for the redesign?)
Comment 5•14 years ago
|
||
Marking this as needed for string freeze in case it needs string changes
blocking2.0: final+ → beta5+
Keywords: uiwanted
Comment 7•14 years ago
|
||
See also attachment 462750 [details] for the broken button on Linux.
Comment 8•14 years ago
|
||
perhaps a tooltip needed instead, to keep the gear icon?
Comment 10•14 years ago
|
||
What was t(In reply to comment #1) > That's what I have seen yesterday too. Its style doesn't match the one from the > mockups: > > https://bug562622.bugzilla.mozilla.org/attachment.cgi?id=442478 An important assumption I had when I made that mockup is, unfortunately, no longer true: that by default, all add-ons would automatically update. It's been confirmed that we can't automatically update plugins. This is important because it means that normal users, who have never touched the add-ons manager, by default will need to manually update their add-ons. This sucks, but it also means that updating is no longer Advanced UI - it's primary and important to surface from anywhere within the add-ons manager. If normal users at any point could have out of date plugins, then normal users should be able to go to the add-on manager and quickly & easily be able to perform such an update.
Comment 11•14 years ago
|
||
(In reply to comment #10) > What was t(In reply to comment #1) > > That's what I have seen yesterday too. Its style doesn't match the one from the > > mockups: > > > > https://bug562622.bugzilla.mozilla.org/attachment.cgi?id=442478 > > An important assumption I had when I made that mockup is, unfortunately, no > longer true: that by default, all add-ons would automatically update. It's > been confirmed that we can't automatically update plugins. This is important > because it means that normal users, who have never touched the add-ons manager, > by default will need to manually update their add-ons. This sucks, but it also > means that updating is no longer Advanced UI - it's primary and important to > surface from anywhere within the add-ons manager. If normal users at any point > could have out of date plugins, then normal users should be able to go to the > add-on manager and quickly & easily be able to perform such an update. This bug has nothing to do with performing updates etc. It is purely about the visual look of the button.
Summary: Update button style should match that of Firefox → Add-ons manager utilities button style needs to be correct on all platforms
Assignee | ||
Comment 12•14 years ago
|
||
(In reply to comment #8) > perhaps a tooltip needed instead, to keep the gear icon? Filed bug 589344 for this. And this bug can remain just for the style changes.
Updated•14 years ago
|
blocking2.0: beta5+ → final+
Comment 14•14 years ago
|
||
Carried over from bug 590175
Updated•14 years ago
|
Attachment #470466 -
Flags: review?(bmcbride)
Assignee | ||
Comment 15•14 years ago
|
||
Comment on attachment 470466 [details] [diff] [review] new icon and button appearance for linux >+ -moz-appearance: button; This isn't needed - buttons have this set already. > min-width: 4.5em; Similarly, this doesn't seem to be needed either (for Linux, at least). > list-style-image: url("chrome://mozapps/skin/extensions/utilities.png"); I played around with this - if you apply list-style-image only to the .button-icon class (ie, #header-utils-btn .button-icon), it doesn't show the double icon. For some reason, the dropmarker is inheriting that style (but only on Linux - haven't looked into why).
Attachment #470466 -
Flags: review?(bmcbride) → review-
Updated•14 years ago
|
Whiteboard: [good first bug]
Comment 17•14 years ago
|
||
>>+ -moz-appearance: button; >This isn't needed - buttons have this set already. Removed. >> min-width: 4.5em; >Similarly, this doesn't seem to be needed either (for Linux, at least). Actually, it appears it does. Without this, the button grows really wide. Also tried with min-width: 16px;, but that was too small. >>list-style-image: url("chrome://mozapps/skin/extensions/utilities.png"); >if you apply list-style-image only to the .button-icon class (ie, #header-utils-btn .button-icon), it doesn't show the double icon. Added.
Attachment #470466 -
Attachment is obsolete: true
Attachment #471090 -
Flags: review?(bmcbride)
Assignee | ||
Comment 18•14 years ago
|
||
Comment on attachment 471090 [details] [diff] [review] Updated patch for Linux (checked in) I'm assuming you're keeping the existing icon on purpose, as opposed to the icon in the first patch. The existing icon will eventually be updated on Windows and OSX (its another gear, but prettier). So the Linux icon can be updated to that too, when its done.
Attachment #471090 -
Flags: review?(bmcbride) → review+
Comment 19•14 years ago
|
||
Oh, crap, didn't I include that in the patch?
Comment 20•14 years ago
|
||
Hm, I think it did get included, maybe it doesn't show in the diff unless you go to View in the patch detail? I can update the icon later on if needed.
Assignee | ||
Comment 21•14 years ago
|
||
Oh, duh. My mistake. The one time I don't look at the raw patch... Still, r+ remains.
Assignee | ||
Updated•14 years ago
|
Keywords: uiwanted → checkin-needed
Comment 22•14 years ago
|
||
So this is ready now for check-in?
Assignee: bmcbride → nisses.mail
Status: NEW → ASSIGNED
Updated•14 years ago
|
Assignee: nisses.mail → bmcbride
Status: ASSIGNED → NEW
Updated•14 years ago
|
Assignee: bmcbride → nisses.mail
Status: NEW → ASSIGNED
Comment 23•14 years ago
|
||
This bug was reported on Windows, the summary says "on all platforms", but the patch is Linux-only. Can someone please clarify?
Keywords: checkin-needed
Comment 24•14 years ago
|
||
Judging from the date I would say windows is already fixed? At least it seems to look fine on recent screenshots. Linux still has the pre-new-listview button. Cannot speak for Mac, but this could be Linux-only right now.
Comment 25•14 years ago
|
||
Windows has the same Mac button style as Linux right now.
Comment 26•14 years ago
|
||
Sorry, I thought the images posted in Boriss' latest blog¹ were actual screenshots. [1] http://jboriss.wordpress.com/
Updated•14 years ago
|
Attachment #471090 -
Attachment description: Updated patch → Updated patch for Linux
Comment 27•14 years ago
|
||
comment 22 redux: The current patch is review+ and even if it's Linux only it looks like it should be committed for now at least to make progress. If other OSes need patching too, then someone can write new patches for them too.
Comment 28•14 years ago
|
||
Comment on attachment 471090 [details] [diff] [review] Updated patch for Linux (checked in) http://hg.mozilla.org/mozilla-central/rev/b07b23448a2d
Attachment #471090 -
Attachment description: Updated patch for Linux → Updated patch for Linux (checked in)
Comment 29•14 years ago
|
||
Andreas, are going to take care of Windows as well?
Comment 30•14 years ago
|
||
Assignee: nisses.mail → dao
Attachment #473470 -
Flags: review?(bmcbride)
Assignee | ||
Comment 31•14 years ago
|
||
Comment on attachment 473470 [details] [diff] [review] the rest According to Boriss's mockups, we don't want native styling on that button on Windows/OSX. See https://bug585950.bugzilla.mozilla.org/attachment.cgi?id=464424 I'll attach the guide Boriss made, that elaborates on a lot of these details.
Attachment #473470 -
Flags: review?(bmcbride) → review-
Assignee | ||
Comment 32•14 years ago
|
||
Updated•14 years ago
|
Assignee: dao → nobody
Reporter | ||
Comment 33•14 years ago
|
||
(In reply to comment #31) > Comment on attachment 473470 [details] [diff] [review] > the rest > > According to Boriss's mockups, we don't want native styling on that button on > Windows/OSX. > See https://bug585950.bugzilla.mozilla.org/attachment.cgi?id=464424 > > I'll attach the guide Boriss made, that elaborates on a lot of these details. Even if that is the case, as shown in attachment 473975 [details], the button styling is clearly wrong.
Comment 34•14 years ago
|
||
What is the guideline for linux? "Wait for an updated guide" or "do what you want"?
Assignee | ||
Comment 35•14 years ago
|
||
(In reply to comment #34) > What is the guideline for linux? It should use native styling/icons/colors wherever applicable. Which means a mockup isn't going to be a lot of help - but the Windows/OSX mockups should be able to act as a guideline (there's little visual difference between them, and no layout differences). (In reply to comment #33) > Even if that is the case, as shown in attachment 473975 [details], the button styling is > clearly wrong. Yes, it is - this bug still needs fixed for Windows/OSX, but just not with native styling.
Status: ASSIGNED → NEW
Assignee | ||
Updated•14 years ago
|
Assignee: nobody → bmcbride
Status: NEW → ASSIGNED
Whiteboard: [good first bug] → [needs 601022]
Assignee | ||
Updated•14 years ago
|
Comment 37•14 years ago
|
||
Fixed by bug 601022, file any remaining issues separately
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Whiteboard: [needs 601022]
Target Milestone: --- → mozilla2.0b8
Comment 38•14 years ago
|
||
Marking as verified fixed with builds on all platforms like Mozilla/5.0 (X11; Linux i686; rv:2.0b8pre) Gecko/20101125 Firefox/4.0b8pre ID:20101125030318
Status: RESOLVED → VERIFIED
Flags: in-testsuite-
Flags: in-litmus-
You need to log in
before you can comment on or make changes to this bug.
Description
•