Closed
Bug 584019
Opened 14 years ago
Closed 14 years ago
Update zoom level when orientation changes
Categories
(Firefox for Android Graveyard :: Panning/Zooming, defect)
Firefox for Android Graveyard
Panning/Zooming
Tracking
(Not tracked)
RESOLVED
DUPLICATE
of bug 597230
People
(Reporter: fabrice, Unassigned)
References
Details
Attachments
(1 file)
4.26 KB,
patch
|
stechz
:
review-
|
Details | Diff | Splinter Review |
After a double-tap zoom, if the orientation of the device changes the zoom factor should be updated to the selected block.
Comment 1•14 years ago
|
||
This patch adds two new messages : - from content to chrome : Browser:ZoomToElement used when changing orientation after a double tap zoom. - from chrome to content : Browser:ZoomToElement:Return to get back the saved rectangle.
Attachment #462737 -
Flags: review?(webapps)
Comment 2•14 years ago
|
||
Comment on attachment 462737 [details] [diff] [review] patch Hey Fabrice, I'm having trouble getting the orientation change to occur while the zoom is animating. In any case, it's a great idea, but we could address a more general problem. Whenever an orientation switch occurs we always seem to go to the bottom of the page! So maybe we could: 1) figure out why orientation switches go to the bottom of the page (also, it seems to be indefinitely checkerboarded until I pan?) 2) when animating and an orientation switch occurs, we should probably skip to the animation's end result immediately If we stop losing our place on an orientation switch I think we've addressed the problem your patch tries to solve. What do you think?
Attachment #462737 -
Flags: review?(webapps) → review-
Reporter | ||
Comment 3•14 years ago
|
||
Ben, Sorry if my description was poorly worded : I can't either get the orientation change *during* the animated zoom. The goal here was to change the zoom factor when we know that the user asked to zoom a given block. I do agree with your 1) & 2) points, but think they may be different issues.
Updated•14 years ago
|
Hardware: x86 → All
Comment 4•14 years ago
|
||
This was fixed by bug 597230.
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → DUPLICATE
You need to log in
before you can comment on or make changes to this bug.
Description
•