Closed
Bug 584029
Opened 14 years ago
Closed 13 years ago
gfxPlatform::Init leaks fontPrefObserver if !prefs
Categories
(Core :: Graphics, defect)
Tracking
()
RESOLVED
WORKSFORME
People
(Reporter: timeless, Assigned: timeless)
References
(Blocks 1 open bug, )
Details
(Keywords: coverity, memory-leak)
Attachments
(1 file)
|
1.12 KB,
patch
|
Details | Diff | Splinter Review |
219 gfxPlatform::Init()
280 FontPrefsObserver *fontPrefObserver = new FontPrefsObserver();
282 nsCOMPtr<nsIPrefBranch2> prefs = do_GetService(NS_PREFSERVICE_CONTRACTID);
283 if (prefs) {
287 }
the code should only call new inside the if block...
Assignee: nobody → timeless
Status: NEW → ASSIGNED
Attachment #463369 -
Flags: review?(bobbyholley+bmo)
|
||
Comment 2•14 years ago
|
||
Comment on attachment 463369 [details] [diff] [review] patch Switching this review to jeff, since he's the new color management owner.
Attachment #463369 -
Flags: review?(bobbyholley+bmo) → review?(jmuizelaar)
|
||
Comment 3•13 years ago
|
||
This code uses mozilla::Preferences now.
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → WORKSFORME
|
|
||
Updated•13 years ago
|
Attachment #463369 -
Flags: review?(jmuizelaar)
|
||
Updated•6 years ago
|
Blocks: coverity-analysis
You need to log in
before you can comment on or make changes to this bug.
Description
•