Closed Bug 584040 Opened 11 years ago Closed 11 years ago

Fix leaky tests

Categories

(Firefox :: Sync, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: philikon, Assigned: philikon)

References

Details

Attachments

(3 files)

A bunch of tests were disabled during the m-c landing due to leaks (see bug 583985). Need to figure out what the leaks are and get them reenabled.
Depends on: 583985
Attached file leaks
Leaks occur in test_bookmark_order.js, test_bookmark_predecessor.js, test_engines_forms_store.js, test_utils_queryAsync.js. All tests do async queries of some form or another, so presumably they're not waiting long enough for them to clean up properly.
Attached patch part 1Splinter Review
Part 1 addressing FormNotifier.js.
Assignee: nobody → philipp
Attachment #462438 - Flags: review?(mconnor)
Attachment #462438 - Flags: review?(mconnor) → review+
Filed follow-up bug 584123 to get rid of FormNotifier.js on trunk altogether.
part 1 was landed on mozilla-central to trigger tinderbox builds:
http://hg.mozilla.org/mozilla-central/rev/8d1f283db769
Attached patch Part 2Splinter Review
Make sure we explicitly nullify the cached services in the BookmarksStore & BookmarksTracker.
Also, explicitly finalize the statement if it was created.
Finally, reenable the tests.
Attachment #462539 - Flags: review?(mconnor)
Attachment #462539 - Flags: review?(mconnor) → review+
Pushed part 2 to m-c. http://hg.mozilla.org/mozilla-central/rev/7869f6618e71

That puts us at 0 disabled tests (on m-c), so we can close this.
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Whiteboard: [needs to land in fx-sync][needs to land in fx-sync-1.4.x][landed in mozilla-central]
Pushed to fx-sync:

part 1: http://hg.mozilla.org/services/fx-sync/rev/2f2d9a183896
part 2: http://hg.mozilla.org/services/fx-sync/rev/cc50291d4538

Didn't push to 1.4.x branch since we didn't land any of the other leak fixes there either.
Whiteboard: [needs to land in fx-sync][needs to land in fx-sync-1.4.x][landed in mozilla-central]
Landed part 2 on 1.4.x as http://hg.mozilla.org/services/fx-sync/rev/8ffabf694239 to keep BookmarkStore in sync with default branch.
Component: Firefox Sync: Backend → Sync
Product: Cloud Services → Firefox
You need to log in before you can comment on or make changes to this bug.