Closed
Bug 584040
Opened 12 years ago
Closed 12 years ago
Fix leaky tests
Categories
(Firefox :: Sync, defect)
Firefox
Sync
Tracking
()
RESOLVED
FIXED
People
(Reporter: philikon, Assigned: philikon)
References
Details
Attachments
(3 files)
33.84 KB,
text/plain
|
Details | |
3.53 KB,
patch
|
mconnor
:
review+
|
Details | Diff | Splinter Review |
6.66 KB,
patch
|
mconnor
:
review+
|
Details | Diff | Splinter Review |
A bunch of tests were disabled during the m-c landing due to leaks (see bug 583985). Need to figure out what the leaks are and get them reenabled.
Assignee | ||
Comment 1•12 years ago
|
||
Leaks occur in test_bookmark_order.js, test_bookmark_predecessor.js, test_engines_forms_store.js, test_utils_queryAsync.js. All tests do async queries of some form or another, so presumably they're not waiting long enough for them to clean up properly.
Assignee | ||
Comment 2•12 years ago
|
||
Part 1 addressing FormNotifier.js.
Assignee: nobody → philipp
Attachment #462438 -
Flags: review?(mconnor)
Updated•12 years ago
|
Attachment #462438 -
Flags: review?(mconnor) → review+
Assignee | ||
Comment 3•12 years ago
|
||
Filed follow-up bug 584123 to get rid of FormNotifier.js on trunk altogether.
Assignee | ||
Comment 4•12 years ago
|
||
part 1 was landed on mozilla-central to trigger tinderbox builds: http://hg.mozilla.org/mozilla-central/rev/8d1f283db769
Comment 5•12 years ago
|
||
Make sure we explicitly nullify the cached services in the BookmarksStore & BookmarksTracker. Also, explicitly finalize the statement if it was created. Finally, reenable the tests.
Attachment #462539 -
Flags: review?(mconnor)
Updated•12 years ago
|
Attachment #462539 -
Flags: review?(mconnor) → review+
Comment 6•12 years ago
|
||
Pushed part 2 to m-c. http://hg.mozilla.org/mozilla-central/rev/7869f6618e71 That puts us at 0 disabled tests (on m-c), so we can close this.
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Whiteboard: [needs to land in fx-sync][needs to land in fx-sync-1.4.x][landed in mozilla-central]
Assignee | ||
Comment 7•12 years ago
|
||
Pushed to fx-sync: part 1: http://hg.mozilla.org/services/fx-sync/rev/2f2d9a183896 part 2: http://hg.mozilla.org/services/fx-sync/rev/cc50291d4538 Didn't push to 1.4.x branch since we didn't land any of the other leak fixes there either.
Whiteboard: [needs to land in fx-sync][needs to land in fx-sync-1.4.x][landed in mozilla-central]
Assignee | ||
Comment 8•12 years ago
|
||
Landed part 2 on 1.4.x as http://hg.mozilla.org/services/fx-sync/rev/8ffabf694239 to keep BookmarkStore in sync with default branch.
Updated•4 years ago
|
Component: Firefox Sync: Backend → Sync
Product: Cloud Services → Firefox
You need to log in
before you can comment on or make changes to this bug.
Description
•