584040 - Fix leaky tests

Status: RESOLVED FIXED

(Firefox :: Sync, defect)

Description

[Philipp von Weitershausen [:philikon]]

A bunch of tests were disabled during the m-c landing due to leaks (see bug 583985). Need to figure out what the leaks are and get them reenabled.

Comment 1

[Philipp von Weitershausen [:philikon]]

Attachment: leaks

Leaks occur in test_bookmark_order.js, test_bookmark_predecessor.js, test_engines_forms_store.js, test_utils_queryAsync.js. All tests do async queries of some form or another, so presumably they're not waiting long enough for them to clean up properly.

Comment 2

[Philipp von Weitershausen [:philikon]]

Attachment: part 1

Part 1 addressing FormNotifier.js.

Comment 3

[Philipp von Weitershausen [:philikon]]

Filed follow-up bug 584123 to get rid of FormNotifier.js on trunk altogether.

Comment 4

[Philipp von Weitershausen [:philikon]]

part 1 was landed on mozilla-central to trigger tinderbox builds:
http://hg.mozilla.org/mozilla-central/rev/8d1f283db769

Comment 5

[Paul O'Shannessy [:zpao] (not reading much bugmail, email directly)]

Attachment: Part 2

Make sure we explicitly nullify the cached services in the BookmarksStore & BookmarksTracker.
Also, explicitly finalize the statement if it was created.
Finally, reenable the tests.

Comment 6

[Paul O'Shannessy [:zpao] (not reading much bugmail, email directly)]

Pushed part 2 to m-c. http://hg.mozilla.org/mozilla-central/rev/7869f6618e71

That puts us at 0 disabled tests (on m-c), so we can close this.

Comment 7

[Philipp von Weitershausen [:philikon]]

Pushed to fx-sync:

part 1: http://hg.mozilla.org/services/fx-sync/rev/2f2d9a183896
part 2: http://hg.mozilla.org/services/fx-sync/rev/cc50291d4538

Didn't push to 1.4.x branch since we didn't land any of the other leak fixes there either.

Comment 8

[Philipp von Weitershausen [:philikon]]

Landed part 2 on 1.4.x as http://hg.mozilla.org/services/fx-sync/rev/8ffabf694239 to keep BookmarkStore in sync with default branch.