584075 - Narcissus: use ExecutionContext.prototype.run instead of push/pop

Status: RESOLVED FIXED

(Other Applications Graveyard :: Narcissus, defect)

Description

[Dave Herman [:dherman]]

ExecutionContexts get pushed and popped when entering/exiting a function activation. Bug 583001 introduces ExecutionContext.prototype.run, which abstracts this pattern. Use this function instead of manually pushing and popping the context.

Dave

Comment 1

[Dave Herman [:dherman]]

Attachment: abstracts out "execute in new ExecutionContext" idiom

The |run| method, which took a thunk and called it, was just a little too general and I found it kind of confusing. I replaced it with a slightly less abstract |execute| method, which takes a Node and executes it in the new context. It also doesn't return a result anymore; instead, the client can make clear what value they want.

Dave

Comment 2

[Dave Herman [:dherman]]

http://hg.mozilla.org/tracemonkey/rev/6d977009d79f