Closed Bug 584075 Opened 12 years ago Closed 12 years ago

Narcissus: use ExecutionContext.prototype.run instead of push/pop

Categories

(Other Applications Graveyard :: Narcissus, defect)

x86
macOS
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: dherman, Assigned: dherman)

References

Details

Attachments

(1 file)

ExecutionContexts get pushed and popped when entering/exiting a function activation. Bug 583001 introduces ExecutionContext.prototype.run, which abstracts this pattern. Use this function instead of manually pushing and popping the context.

Dave
Assignee: dherman → nobody
Component: JavaScript Engine → Narcissus
Product: Core → Other Applications
QA Contact: general → narcissus
Keywords: narcissus
Blocks: 584777
The |run| method, which took a thunk and called it, was just a little too general and I found it kind of confusing. I replaced it with a slightly less abstract |execute| method, which takes a Node and executes it in the new context. It also doesn't return a result anymore; instead, the client can make clear what value they want.

Dave
Assignee: nobody → dherman
Attachment #464460 - Flags: review?(taustin)
Attachment #464460 - Flags: review?(taustin) → review+
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Product: Other Applications → Other Applications Graveyard
You need to log in before you can comment on or make changes to this bug.