Closed
Bug 584103
Opened 15 years ago
Closed 15 years ago
njs --harmony / -H
Categories
(Other Applications Graveyard :: Narcissus, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: dherman, Assigned: dherman)
Details
Attachments
(1 file)
|
2.05 KB,
patch
|
taustin
:
review+
|
Details | Diff | Splinter Review |
The njs script should take a command-line argument to enable Harmony mode.
Dave
|
Assignee | |
Updated•15 years ago
|
Component: JavaScript Engine → Narcissus
Product: Core → Other Applications
QA Contact: general → narcissus
|
|
Assignee | |
Comment 1•15 years ago
|
||
This patch applies on top of the patch for bug 583001.
Dave
Attachment #463351 -
Flags: review?(taustin)
|
||
Comment 2•15 years ago
|
||
Comment on attachment 463351 [details] [diff] [review]
adds -H/--harmony flag to njs and "harmony" version
>+ if options.js_harmony:
>+ cmd += 'Narcissus.options={version:"harmony"}; '
>+ else:
>+ cmd += 'Narcissus.options={version:185}; '
>+
Instead of setting the default version in njs, perhaps it is better to set it in jsdefs.js? Otherwise we would need to explicitly set the version when embedding Narcissus within a browser.
Otherwise, looks good to me.
Attachment #463351 -
Flags: review?(taustin) → review+
|
|
Assignee | |
Comment 3•15 years ago
|
||
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
|
||
Updated•6 years ago
|
Product: Other Applications → Other Applications Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•