584164 - dehydra: use finish_decl callback

Status: RESOLVED FIXED

(Developer Infrastructure :: Source Code Analysis, defect)

Description

[Ehren Metcalfe]

Attachment: patch

I looked into using bhackett's patch (https://bugzilla.mozilla.org/show_bug.cgi?id=559964#c70) to replace more of the core plugin eg remove the global_namespace processing... didn't have too much success. This patch will give us process_tree_decl with C though. (Uses --with-finish-decl configure option)

Comment 1

[(dormant account)]

Comment on attachment 462484 [details] [diff] [review]
patch

>+        elif o == "--with-finish-decl":
>+            finishdecl = True

I'd rather configure execute a program to check if PLUGIN_FINISH_DECL is defined.

Comment 2

[Ehren Metcalfe]

Attachment: patch v2

with configure time compile

Comment 3

[(dormant account)]

Comment on attachment 463229 [details] [diff] [review]
patch v2

> 
>+def try_enable_finish_decl(config):
>+    print("Checking for FINISH_DECL callback:")
>+    cxx = config["CXX"]
>+    cout, cin = popen2.popen2("mktemp --suffix=.c")
>+    fname = cout.read()
>+    popen2.popen2("echo '#include \"gcc-plugin.h\"\nenum plugin_event p = PLUGIN_FINISH_DECL;' > " + fname)

I believe Python has a triple """ multiline quote for this :)
 
>+    cmd = "cc -c -o /dev/null " + config["GCC_PLUGIN_HEADERS"] + " " + fname
>+    cout, cin, cerr = popen2.popen3(cmd)
>+    if len(cerr.read()) == 0:

Check the exit code instead.

>+        config['FINISH_DECL'] = "yes"
>+        print("FINISH_DECL callback enabled");
>+    else:
>+        print("FINISH_DECL callback disabled");
>+    popen2.popen2("rm -f " + fname)

Use a python function for deleting.

Comment 4

[Ehren Metcalfe]

Attachment: patch v3

might do it

Comment 5

[(dormant account)]

Comment on attachment 463345 [details] [diff] [review]
patch v3


>+def try_enable_finish_decl(config):
>+    print("Checking for FINISH_DECL callback:")
>+    cxx = config["CXX"]
>+    cout, cin = popen2.popen2("mktemp --suffix=.c")
>+    fname = cout.read().rstrip()
>+    popen2.popen2("""echo '#include "gcc-plugin.h"
>+                           enum plugin_event p = PLUGIN_FINISH_DECL;' > """ + fname)

Sorry, I didn't even notice the echo in there.
Use python's tempfile api to generate file. Write to file from python. This isn't a shell program :)

format the quoted stuff on own lines
.write(
"""#include <>
..."""
)

Almost there.

Comment 6

[Ehren Metcalfe]

Attachment: patch v4

a bit more pythonic

Comment 7

[(dormant account)]

Comment on attachment 463385 [details] [diff] [review]
patch v4

Nice

Comment 8

[Ehren Metcalfe]

http://hg.mozilla.org/rewriting-and-analysis/dehydra/rev/b3c0146edc05