Closed
Bug 584181
Opened 14 years ago
Closed 14 years ago
When there are no reviews, the link to "Reviews" in the breadcrumb is a 404
Categories
(addons.mozilla.org Graveyard :: Public Pages, defect, P5)
addons.mozilla.org Graveyard
Public Pages
Tracking
(Not tracked)
VERIFIED
FIXED
5.12.2
People
(Reporter: stephend, Assigned: jbalogh)
References
()
Details
STR: 1. Load https://preview.addons.mozilla.org/z/en-US/firefox/addon/64250/reviews/229627/ or https://preview.addons.mozilla.org/z/en-US/firefox/addon/64250/reviews/add *when the add-on doesn't have any reviews* 2. Click on the breadcrumb for "Reviews" (https://preview.addons.mozilla.org/z/en-US/firefox/addon/64250/reviews/) Actual: You'll get a 404.
|
Assignee | |
Updated•14 years ago
|
Assignee: nobody → mbasta
Target Milestone: 5.11.7 → 5.11.8
|
||
Comment 1•14 years ago
|
||
Sorry about all the github pollution, but it got fixed in an unexpected commit: http://github.com/mattbasta/zamboni/commit/18a7bcc001a30b3ec4b2d14d34a39b8954806c16
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
|
|
Assignee | |
Comment 2•14 years ago
|
||
Doesn't count as fixed until it's reviewed and committed to the master repo.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
|
|
||
Comment 3•14 years ago
|
||
http://github.com/mattbasta/zamboni/commit/a65c085a6a12efec02cb4f07cecdaa776fa06504
|
||
Comment 4•14 years ago
|
||
If there are no reviews, the reviews page should say there are no reviews instead of being 404.
|
|
||
Comment 5•14 years ago
|
||
http://github.com/mattbasta/zamboni/commit/558237bc751f433903da27f2040e0ab1f22924c5
|
|
||
Comment 6•14 years ago
|
||
also: http://github.com/mattbasta/zamboni/commit/de4b4492f2641db36a6c8c30ab43bea5674edadf
|
||
Updated•14 years ago
|
Target Milestone: 5.11.8 → 5.11.9
|
|
Assignee | |
Updated•14 years ago
|
Assignee: mbasta → jbalogh
|
|
Assignee | |
Updated•14 years ago
|
Target Milestone: 5.11.9 → 4.x (triaged)
|
||
Updated•14 years ago
|
Target Milestone: 4.x (triaged) → 5.12
|
|
||
Updated•14 years ago
|
Priority: -- → P5
|
|
||
Updated•14 years ago
|
Target Milestone: 5.12 → 5.12.1
|
|
||
Updated•14 years ago
|
Target Milestone: 5.12.1 → 5.12.2
|
|
Assignee | |
Comment 7•14 years ago
|
||
http://github.com/jbalogh/zamboni/commit/13286ed
Status: REOPENED → RESOLVED
Closed: 14 years ago → 14 years ago
Resolution: --- → FIXED
|
Reporter | |
Comment 8•14 years ago
|
||
Verified FIXED: * https://preview.addons.mozilla.org/en-US/firefox/addon/64250/reviews/ now says: "Reviews for he-he,ha-ha 0 reviews for this add-on Be the first to write a review." * https://preview.addons.mozilla.org/z/en-US/firefox/addon/64250/reviews/add is fine too
Status: RESOLVED → VERIFIED
|
||
Updated•8 years ago
|
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•