584189 - Migrate /recommended/format:rss

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Public Pages, defect)

Description

[Wil Clouser [:clouserw]]

We need to migrate https://preview.addons.mozilla.org/en-US/firefox/recommended/format:rss to zamboni.  It should end up (with a redirect) at:

https://preview.addons.mozilla.org/en-US/firefox/featured/format:rss

This bug includes:
- Building the RSS output (and making sure it validates)
- Changing the <link> on the /featured page to point to the new url

Comment 1

[Robert Helmer [:rhelmer]]

Let me know how this looks:
http://github.com/rhelmer/zamboni/commit/d5376e0c3210b795414903284c831016f7cd716e

I based this on how some of the other feeds in zamboni are done (reviews, versions), and there are some minor differences from the remora version:

* channel/lastBuildDate instead of channel/pubDate
* no formatting whitespace (linefeeds etc)
* use copy from new /featured/ page for channel/description
** left out the conditional part about rockyourfirefox.com

Comment 2

[Wil Clouser [:clouserw]]

Comments are on the commit, but I couldn't get it to show up due to a traceback.  The first 3 are fine, I'm not sure what you mean by the conditional part, but I figured I'd compare when I could get it to show up.

Comment 3

[Robert Helmer [:rhelmer]]

(In reply to comment #2)
> Comments are on the commit, but I couldn't get it to show up due to a
> traceback.  The first 3 are fine, I'm not sure what you mean by the conditional
> part, but I figured I'd compare when I could get it to show up.

Working my way through the comments, thanks!

Sorry about that stacktrace, I just pushed a fix for that (added more data to the fixture so this is unit-testable but that's not checked in yet, I haven't made sure it works with other tests), if you want to get a working feed this *should* work now:

http://github.com/rhelmer/zamboni/commit/a980a88e676a37c54a878f1a968f273d7abdb233

The "conditional part" I meant is "Be sure to visit Rock Your Firefox to learn about other useful add-ons every week!", which only shows for Firefox on the HTML page but is absent for other products.

Comment 4

[Pratibha]

would this also cover the issue: the default title for the Live Bookmark created on ToolBar is now "Recommended Add-ons :: Add-ons for Firefox"

to "Featured Add-ons :: Add-ons for Firefox"

Comment 5

[Wil Clouser [:clouserw]]

(In reply to comment #3)
> (In reply to comment #2)
> > Comments are on the commit, but I couldn't get it to show up due to a
> > traceback.  The first 3 are fine, I'm not sure what you mean by the conditional
> > part, but I figured I'd compare when I could get it to show up.
> 
> Working my way through the comments, thanks!
> 
> Sorry about that stacktrace, I just pushed a fix for that (added more data to
> the fixture so this is unit-testable but that's not checked in yet, I haven't
> made sure it works with other tests), if you want to get a working feed this
> *should* work now:
> 
> http://github.com/rhelmer/zamboni/commit/a980a88e676a37c54a878f1a968f273d7abdb233
> 
> The "conditional part" I meant is "Be sure to visit Rock Your Firefox to learn
> about other useful add-ons every week!", which only shows for Firefox on the
> HTML page but is absent for other products.

This works, thanks.  It looks good.

(In reply to comment #4)
> would this also cover the issue: the default title for the Live Bookmark
> created on ToolBar is now "Recommended Add-ons :: Add-ons for Firefox"
> 
> to "Featured Add-ons :: Add-ons for Firefox"

It doesn't right now, but it's an easy fix.  Rhelmer, can you add that before the final patch?

Comment 6

[Robert Helmer [:rhelmer]]

http://github.com/rhelmer/zamboni/commit/fda92adf4a7837e0aaf3c01b9fe1261ec57c3520

Addresses review comments from github link in comment #1, except for jbalogh's comment about page_title helper (responded to that here http://github.com/rhelmer/zamboni/commit/d5376e0c3210b795414903284c831016f7cd716e#commitcomment-124437)

(In reply to comment #5)
> (In reply to comment #4)
> > would this also cover the issue: the default title for the Live Bookmark
> > created on ToolBar is now "Recommended Add-ons :: Add-ons for Firefox"
> > 
> > to "Featured Add-ons :: Add-ons for Firefox"
> 
> It doesn't right now, but it's an easy fix.  Rhelmer, can you add that before
> the final patch?

Got it in this one as well.

Comment 7

[Robert Helmer [:rhelmer]]

(In reply to comment #6)
> http://github.com/rhelmer/zamboni/commit/fda92adf4a7837e0aaf3c01b9fe1261ec57c3520

Forgot to mention, I adjusted the features.json to have two featured add-ons, to test cases where multiple items are returned (pointed out in the reviews for comment 1.)

Comment 8

[Robert Helmer [:rhelmer]]

jbalogh and I went over this in IRC a bit; I believe that this addresses all outstanding comments, and I also did a merge and dealt with the conflicts:

http://github.com/rhelmer/zamboni/commit/5f03c722e34d733514751565b208439ff01e5d10

Comment 9

[Jeff Balogh (:jbalogh)]

Thanks! http://github.com/jbalogh/zamboni/commit/450ccc0

Comment 10

[Stephen Donner [:stephend] Not actively reading bugmail]

Hopefully I waited long enough for preview to pick up the changes from Github:

1. https://preview.addons.mozilla.org/en-US/firefox/recommended/format:rss doesn't redirect to https://preview.addons.mozilla.org/en-US/firefox/featured/format:rss (guess we need a separate .htaccess / IT bug?)
2. https://preview.addons.mozilla.org/en-US/firefox/featured/format:rss returns a 500
3. https://preview.addons.mozilla.org/en-US/firefox/featured still points to https://preview.addons.mozilla.org/en-US/firefox/extensions/all/format:rss?sort=updated and https://preview.addons.mozilla.org/en-US/firefox/recommended/format:rss (last comment in comment 0 makes me think it should only link to one).

Comment 11

[Jeff Balogh (:jbalogh)]

1. Use /z
2. Use /z
3. The frontpage still needs to be updated
3.5 That's weird and it sounds like a different but.

Comment 12

[Stephen Donner [:stephend] Not actively reading bugmail]

You can re-close, I guess, I've filed a new "but": bug 588675.

Comment 13

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified.