Closed Bug 584189 Opened 16 years ago Closed 15 years ago

Migrate /recommended/format:rss

Categories

(addons.mozilla.org Graveyard :: Public Pages, defect)

Product:
addons.mozilla.org Graveyard
Component:
Public Pages
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
VERIFIED FIXED
Milestone:
5.11.8

People

(Reporter: clouserw, Assigned: rhelmer)

References

(
URL
)

Details

We need to migrate https://preview.addons.mozilla.org/en-US/firefox/recommended/format:rss to zamboni. It should end up (with a redirect) at: https://preview.addons.mozilla.org/en-US/firefox/featured/format:rss This bug includes: - Building the RSS output (and making sure it validates) - Changing the <link> on the /featured page to point to the new url
Assignee: nobody → robert
Target Milestone: --- → 5.11.8
Let me know how this looks: http://github.com/rhelmer/zamboni/commit/d5376e0c3210b795414903284c831016f7cd716e I based this on how some of the other feeds in zamboni are done (reviews, versions), and there are some minor differences from the remora version: * channel/lastBuildDate instead of channel/pubDate * no formatting whitespace (linefeeds etc) * use copy from new /featured/ page for channel/description ** left out the conditional part about rockyourfirefox.com
Comments are on the commit, but I couldn't get it to show up due to a traceback. The first 3 are fine, I'm not sure what you mean by the conditional part, but I figured I'd compare when I could get it to show up.
(In reply to comment #2) > Comments are on the commit, but I couldn't get it to show up due to a > traceback. The first 3 are fine, I'm not sure what you mean by the conditional > part, but I figured I'd compare when I could get it to show up. Working my way through the comments, thanks! Sorry about that stacktrace, I just pushed a fix for that (added more data to the fixture so this is unit-testable but that's not checked in yet, I haven't made sure it works with other tests), if you want to get a working feed this *should* work now: http://github.com/rhelmer/zamboni/commit/a980a88e676a37c54a878f1a968f273d7abdb233 The "conditional part" I meant is "Be sure to visit Rock Your Firefox to learn about other useful add-ons every week!", which only shows for Firefox on the HTML page but is absent for other products.
would this also cover the issue: the default title for the Live Bookmark created on ToolBar is now "Recommended Add-ons :: Add-ons for Firefox" to "Featured Add-ons :: Add-ons for Firefox"
(In reply to comment #3) > (In reply to comment #2) > > Comments are on the commit, but I couldn't get it to show up due to a > > traceback. The first 3 are fine, I'm not sure what you mean by the conditional > > part, but I figured I'd compare when I could get it to show up. > > Working my way through the comments, thanks! > > Sorry about that stacktrace, I just pushed a fix for that (added more data to > the fixture so this is unit-testable but that's not checked in yet, I haven't > made sure it works with other tests), if you want to get a working feed this > *should* work now: > > http://github.com/rhelmer/zamboni/commit/a980a88e676a37c54a878f1a968f273d7abdb233 > > The "conditional part" I meant is "Be sure to visit Rock Your Firefox to learn > about other useful add-ons every week!", which only shows for Firefox on the > HTML page but is absent for other products. This works, thanks. It looks good. (In reply to comment #4) > would this also cover the issue: the default title for the Live Bookmark > created on ToolBar is now "Recommended Add-ons :: Add-ons for Firefox" > > to "Featured Add-ons :: Add-ons for Firefox" It doesn't right now, but it's an easy fix. Rhelmer, can you add that before the final patch?
http://github.com/rhelmer/zamboni/commit/fda92adf4a7837e0aaf3c01b9fe1261ec57c3520 Addresses review comments from github link in comment #1, except for jbalogh's comment about page_title helper (responded to that here http://github.com/rhelmer/zamboni/commit/d5376e0c3210b795414903284c831016f7cd716e#commitcomment-124437) (In reply to comment #5) > (In reply to comment #4) > > would this also cover the issue: the default title for the Live Bookmark > > created on ToolBar is now "Recommended Add-ons :: Add-ons for Firefox" > > > > to "Featured Add-ons :: Add-ons for Firefox" > > It doesn't right now, but it's an easy fix. Rhelmer, can you add that before > the final patch? Got it in this one as well.
(In reply to comment #6) > http://github.com/rhelmer/zamboni/commit/fda92adf4a7837e0aaf3c01b9fe1261ec57c3520 Forgot to mention, I adjusted the features.json to have two featured add-ons, to test cases where multiple items are returned (pointed out in the reviews for comment 1.)
jbalogh and I went over this in IRC a bit; I believe that this addresses all outstanding comments, and I also did a merge and dealt with the conflicts: http://github.com/rhelmer/zamboni/commit/5f03c722e34d733514751565b208439ff01e5d10
Thanks! http://github.com/jbalogh/zamboni/commit/450ccc0
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
1. Use /z 2. Use /z 3. The frontpage still needs to be updated 3.5 That's weird and it sounds like a different but.
You can re-close, I guess, I've filed a new "but": bug 588675.
Depends on: 588675
Status: REOPENED → RESOLVED
Closed: 15 years ago → 15 years ago
Resolution: --- → FIXED
Verified.
Status: RESOLVED → VERIFIED
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in before you can comment on or make changes to this bug.