584218 - Android sutagent needs ability to update itself

Status: RESOLVED FIXED

(Testing :: General, defect)

Description

[cmtalbert]

Attachment: This is a patch that achieves this. It also adds some images for error messages. Still needs some makefile love.

It would be really awesome if the sutagent could update itself with a new copy.  Additionally, we'd also like to be able to update any application on the phone.  This way we have a mechanism to reinstall fennec easily as well as the agent.

Comment 1

[Bob Moss :bmoss]

Comment on attachment 462550 [details] [diff] [review]
This is a patch that achieves this.  It also adds some images for error messages.  Still needs some makefile love.

This looks good, remember to change the makefiles to pick up the graphics.

Comment 2

[cmtalbert]

Attachment: Patch v2

This patch adds in a command to get the version of the sutAgent.  Joel and I could have sworn that we had all already done this, but I couldn't find it in any of the code either in this patch, m-c, or in remote-testing.  So, I went ahead and added it.  

This patch also includes the make file changes to pick up the graphics.

Comment 3

[cmtalbert]

Attachment: Agent with Bmoss's latest code

Ok, so I had the wrong version of Bob's code, which did not have the version bit.  This new bit is based off Bob's real version code, plus his fix to update the agent in place, with a couple of cleanup patches to the help file.  I've r+'d Bmoss's code, and thrown out my own version of this patch. 

Bob, please double check, and make sure we have the issues sorted out now.

Comment 4

[Bob Moss :bmoss]

Good to go.

Comment 5

[cmtalbert]

Landed: http://hg.mozilla.org/mozilla-central/rev/fa73e81c1e87

Comment 6

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

You added rejects:
build/mobile/sutagent/android/res/drawable/ateamlogo.png.rej
build/mobile/sutagent/android/res/drawable/ic_stat_first.png.rej
build/mobile/sutagent/android/res/drawable/ic_stat_neterror.png.rej
build/mobile/sutagent/android/res/drawable/ic_stat_second.png.rej
build/mobile/sutagent/android/res/drawable/ic_stat_warning.png.rej

Please back these out.

Comment 7

[cmtalbert]

(In reply to comment #6)
> You added rejects:
> build/mobile/sutagent/android/res/drawable/ateamlogo.png.rej
> build/mobile/sutagent/android/res/drawable/ic_stat_first.png.rej
> build/mobile/sutagent/android/res/drawable/ic_stat_neterror.png.rej
> build/mobile/sutagent/android/res/drawable/ic_stat_second.png.rej
> build/mobile/sutagent/android/res/drawable/ic_stat_warning.png.rej
> 
> Please back these out.
Sure thing.  I thought I'd deleted these before finishing the patch.

I have another patch I'm landing today, so I'll co land this removal with that to save on infrastructure impact. 

Thanks for letting me know, and I apologize for that!

Comment 8

[cmtalbert]

Ok, that landing stuck, those rej files are a thing of the past.  Sorry about that.

http://hg.mozilla.org/mozilla-central/rev/2a539b9317e2

Comment 9

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Thanks!

Comment 10

[Martijn Wargers (dead)]

Shouldn't the 'updt' command be added to the help output?

Comment 11

[Bob Moss :bmoss]

This will be part of the next patch to address the 'clok' command.