584263 - Need a way to notify changing of tab's visibility

Status: RESOLVED FIXED

(Firefox :: Tabbed Browser, enhancement)

Description

[YUKI "Piro" Hiroshi]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; ja; rv:1.9.2.8) Gecko/20100723 Ubuntu/10.04 (lucid) Firefox/3.6.8
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; ja; rv:1.9.2.8) Gecko/20100723 Ubuntu/10.04 (lucid) Firefox/3.6.8

https://bugzilla.mozilla.org/show_bug.cgi?id=582116
By this bug, APIs to control visibility of set of tabs become available.

This API modifies the value of "hidden" attribute of tabs. "hidden" is based on CSS's "display:none", and changing of "display" property breaks DOM structure of the element. So, some addons have to re-initialize the tab when it becomes visible from invisible.

Another case, some tab-related addons don't want to observe hidden tabs to save system performance. To start/stop observation of tabs automatically, we need an event which notifies changing of tab's visibility. For this purpose, "DOMAttrModified" is too generic.


Reproducible: Always

Comment 1

[YUKI "Piro" Hiroshi]

Can I use setter for "hidden" property of each <tab> element?

Comment 2

[:Gavin Sharp [email: [e-mail]]]

(In reply to comment #0)
> This API modifies the value of "hidden" attribute of tabs. "hidden" is based on
> CSS's "display:none", and changing of "display" property breaks DOM structure
> of the element. So, some addons have to re-initialize the tab when it becomes
> visible from invisible.

What do you mean by "re-initialize"? Styles will be applied automatically, but it won't be synchronously. What parts are you relying on being initialized?

Comment 3

[YUKI "Piro" Hiroshi]

I'm very sorry, I misunderstood the effect of hidden="true" (display:none) on two points.

1) Because <browser/> element was completely broken after changing hidden attribute true to false, I thought that any XUL element are broken by the attribute.

2) Because moving of tabs does modify the DOM structure, some addons such dynamically inserts custom DOM elements (canvas for thumbnail, etc.) have to re-initialize the moved tab by TabMove event. I confused hidden="true" with this.

Comment 4

[:Gavin Sharp [email: [e-mail]]]

Can we WONTFIX this, then?

Comment 5

[YUKI "Piro" Hiroshi]

I don't think so because this still there:

> Another case, some tab-related addons don't want to observe hidden tabs to save
> system performance. To start/stop observation of tabs automatically, we need an
> event which notifies changing of tab's visibility. For this purpose,
> "DOMAttrModified" is too generic.

Comment 6

[Ed Lee :Mardak]

The bookmark all tabs context menu item changes state based on TabOpen/Close notifications, so hiding all but one tab results in it not being correctly grayed out. Bug 585855. Should we be using a notification to track that?

Comment 7

[:Gavin Sharp [email: [e-mail]]]

Sounds like it. I suppose we could add TabHidden/TabUnhidden...

Comment 8

[Dão Gottwald [:dao]]

(In reply to comment #7)
> Sounds like it. I suppose we could add TabHidden/TabUnhidden...

Bug 585855 is doing this.

Comment 9

[:Gavin Sharp [email: [e-mail]]]

Fixed by bug 585855: TabShow/TabHide events are now fired on visibility changes.