Closed Bug 584298 Opened 14 years ago Closed 14 years ago

Speed up ReadableToJSVal a bit more

Categories

(Core :: XPConnect, defect, P1)

x86
macOS
defect

Tracking

()

RESOLVED FIXED
mozilla2.0b4

People

(Reporter: bzbarsky, Assigned: bzbarsky)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

We're penalizing the fast codepaths in favor of the slow ones right now.  That seems wrong.  Move work out of the guts and into the slow codepaths that actually need it.
Blocks: domperf
Priority: -- → P1
Attached patch Like soSplinter Review
Attachment #462699 - Flags: review?(jst)
Attachment #462699 - Flags: approval2.0?
Summary: Speed up ReadableToJSVal a bit more → [FIX]Speed up ReadableToJSVal a bit more
Summary: [FIX]Speed up ReadableToJSVal a bit more → Speed up ReadableToJSVal a bit more
Whiteboard: [need review]
Attachment #462699 - Flags: approval2.0?
Attachment #462699 - Flags: review?(jst) → review+
Comment on attachment 462699 [details] [diff] [review]
Like so

Safe performance win.
Attachment #462699 - Flags: approval2.0?
Whiteboard: [need review] → [need approval]
Attachment #462699 - Flags: approval2.0? → approval2.0+
Whiteboard: [need approval] → [need landing]
Pushed http://hg.mozilla.org/mozilla-central/rev/4ba110e42f25
Status: NEW → RESOLVED
Closed: 14 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → mozilla2.0b4
Whiteboard: [need landing]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: