584318 - Remove dead code in the Vector C++ classes

Status: RESOLVED FIXED

(Tamarin Graveyard :: Library, defect)

Description

[Lars T Hansen]

Some methods are 64-bit specific; some methods are not used anywhere (some of them appear to be premature, others are probably desirable but unused optimizations).

Comment 1

[Lars T Hansen]

Attachment: Patch

Removes code, #ifdefs code, changes nativegen.py to emit #ifdefs, changes to builtin.cpp.  But a small patch overall.

Comment 2

[Lars T Hansen]

tamarin-redux changeset:   4975:ef2e1e6b152d

Comment 3

[Felix S. Klock II [:pnkfelix, :fklock]]

(In reply to comment #1)
> Created attachment 462736 [details] [diff] [review]
> Patch
> 
> Removes code, #ifdefs code, changes nativegen.py to emit #ifdefs, changes to
> builtin.cpp.  But a small patch overall.

Did this make all methods in SlotOffsetsAndAsserts private when DEBUG is not set?

(Such a condition is apparently worth a warning, and that warning is promoted to an error on the android build I am attempting to get set up.)


You may want to wrap getSlotOffset in a similar DEBUG guard... (yuck).

Comment 4

[Lars T Hansen]

(In reply to comment #3)
> (In reply to comment #1)
> > Created attachment 462736 [details] [diff] [review] [details]
> > Patch
> > 
> > Removes code, #ifdefs code, changes nativegen.py to emit #ifdefs, changes to
> > builtin.cpp.  But a small patch overall.
> 
> Did this make all methods in SlotOffsetsAndAsserts private when DEBUG is not
> set?

Not that I remember.  I made some methods private unconditionally, though.