Closed
Bug 584318
Opened 14 years ago
Closed 14 years ago
Remove dead code in the Vector C++ classes
Categories
(Tamarin Graveyard :: Library, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: lhansen, Assigned: lhansen)
References
Details
(Whiteboard: has-patch)
Attachments
(1 file)
13.63 KB,
patch
|
edwsmith
:
review+
|
Details | Diff | Splinter Review |
Some methods are 64-bit specific; some methods are not used anywhere (some of them appear to be premature, others are probably desirable but unused optimizations).
Assignee | ||
Comment 1•14 years ago
|
||
Removes code, #ifdefs code, changes nativegen.py to emit #ifdefs, changes to builtin.cpp. But a small patch overall.
Attachment #462736 -
Flags: review?(edwsmith)
Assignee | ||
Updated•14 years ago
|
Whiteboard: has-patch
Updated•14 years ago
|
Attachment #462736 -
Flags: review?(edwsmith) → review+
Assignee | ||
Comment 2•14 years ago
|
||
tamarin-redux changeset: 4975:ef2e1e6b152d
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Updated•14 years ago
|
Blocks: vector-tracker
Comment 3•14 years ago
|
||
(In reply to comment #1) > Created attachment 462736 [details] [diff] [review] > Patch > > Removes code, #ifdefs code, changes nativegen.py to emit #ifdefs, changes to > builtin.cpp. But a small patch overall. Did this make all methods in SlotOffsetsAndAsserts private when DEBUG is not set? (Such a condition is apparently worth a warning, and that warning is promoted to an error on the android build I am attempting to get set up.) You may want to wrap getSlotOffset in a similar DEBUG guard... (yuck).
Assignee | ||
Comment 4•14 years ago
|
||
(In reply to comment #3) > (In reply to comment #1) > > Created attachment 462736 [details] [diff] [review] [details] > > Patch > > > > Removes code, #ifdefs code, changes nativegen.py to emit #ifdefs, changes to > > builtin.cpp. But a small patch overall. > > Did this make all methods in SlotOffsetsAndAsserts private when DEBUG is not > set? Not that I remember. I made some methods private unconditionally, though.
You need to log in
before you can comment on or make changes to this bug.
Description
•