Closed
Bug 584569
Opened 16 years ago
Closed 16 years ago
transform matrix() function doesn't handle calc() correctly
Categories
(Core :: CSS Parsing and Computation, defect)
Core
CSS Parsing and Computation
Tracking
()
RESOLVED
FIXED
| Tracking | Status | |
|---|---|---|
| blocking2.0 | --- | final+ |
People
(Reporter: dbaron, Assigned: dbaron)
References
Details
Attachments
(1 file)
|
4.00 KB,
patch
|
bzbarsky
:
review+
|
Details | Diff | Splinter Review |
I noticed assertions in test_value_computation.html that pointed to the problem that in bug 531344 patch 6, I didn't fix nsStyleTransformMatrix to handle the calc() expressions that I accepted and serialized as part of matrix() functions.
This patch fixes that, and fixes the assertions.
(I viewed the change as moving ProcessTranslatePart and LengthPercentPairCalcOps up, but the single function I moved them up across was much smaller than they are. *And* I was modifying that one function a bit.)
Attachment #463009 -
Flags: review?(bzbarsky)
|
||
Comment 1•16 years ago
|
||
Comment on attachment 463009 [details] [diff] [review]
patch
r=bzbarsky
Attachment #463009 -
Flags: review?(bzbarsky) → review+
|
Assignee | |
Updated•16 years ago
|
blocking2.0: --- → final+
|
|
Assignee | |
Comment 2•16 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•