transform matrix() function doesn't handle calc() correctly

RESOLVED FIXED

Status

()

Core
CSS Parsing and Computation
RESOLVED FIXED
8 years ago
8 years ago

People

(Reporter: dbaron, Assigned: dbaron)

Tracking

Trunk
Points:
---

Firefox Tracking Flags

(blocking2.0 final+)

Details

Attachments

(1 attachment)

(Assignee)

Description

8 years ago
Created attachment 463009 [details] [diff] [review]
patch

I noticed assertions in test_value_computation.html that pointed to the problem that in bug 531344 patch 6, I didn't fix nsStyleTransformMatrix to handle the calc() expressions that I accepted and serialized as part of matrix() functions.

This patch fixes that, and fixes the assertions.

(I viewed the change as moving ProcessTranslatePart and LengthPercentPairCalcOps up, but the single function I moved them up across was much smaller than they are.  *And* I was modifying that one function a bit.)
Attachment #463009 - Flags: review?(bzbarsky)
Comment on attachment 463009 [details] [diff] [review]
patch

r=bzbarsky
Attachment #463009 - Flags: review?(bzbarsky) → review+
(Assignee)

Updated

8 years ago
blocking2.0: --- → final+
(Assignee)

Comment 2

8 years ago
http://hg.mozilla.org/mozilla-central/rev/5e1c277df3d1
Status: ASSIGNED → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.