Closed Bug 584571 Opened 15 years ago Closed 15 years ago

Allow the Web Console to be separately themed on Linux

Categories

(DevTools :: General, defect)

Product:
DevTools
Component:
General
Platform:
All
Linux
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: pcwalton, Assigned: pcwalton)

References

Details

(Whiteboard: [kd4b4])

Attachments

(2 files, 2 obsolete files)

Proposed patch, version 3.
1.14 KB, patch
Gavin
: review+
ddahl
: feedback+
Gavin
: approval2.0+
Details | Diff | Splinter Review
[checked-in] Proposed patch (trunk rebase 2010-08-10).
1.31 KB, patch
Details | Diff | Splinter Review
Attached patch Proposed patch. (obsolete) — — Splinter Review
Currently, the Web Console (headsUpDisplay.css) has no theme for Linux. Rather it uses the Windows one. This will be a problem for the close button (bug 581231). The attached patch fixes this.
Attachment #463010 - Flags: feedback?(ddahl)
Attached patch Proposed patch, version 2. (obsolete) — — Splinter Review
New patch fixes the copyright header, sorry about that.
Attachment #463010 - Attachment is obsolete: true
Attachment #463012 - Flags: feedback?(ddahl)
Attachment #463010 - Flags: feedback?(ddahl)
Whiteboard: [kd4b4]
You can |hg cp| the theme file to preserve its history (and make the patch easier to review).
New patch uses hg cp.
Attachment #463012 - Attachment is obsolete: true
Attachment #463237 - Flags: feedback?(ddahl)
Attachment #463012 - Flags: feedback?(ddahl)
Attachment #463237 - Flags: feedback?(ddahl) → feedback+
Attachment #463237 - Flags: review?(dietrich)
Attachment #463237 - Flags: review?(dietrich)
Attachment #463237 - Flags: review+
Attachment #463237 - Flags: approval2.0+
Keywords: checkin-needed
The patch in this bug does not apply.
Keywords: checkin-needed
Rebased to trunk. Only issue was that my name was already added to the file credits, so I assume this doesn't need re-review?
Keywords: checkin-needed
Comment on attachment 464580 [details] [diff] [review] [checked-in] Proposed patch (trunk rebase 2010-08-10). http://hg.mozilla.org/mozilla-central/rev/838edca9178f
Attachment #464580 - Attachment description: Proposed patch (trunk rebase 2010-08-10). → [checked-in] Proposed patch (trunk rebase 2010-08-10).
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Comment on attachment 464580 [details] [diff] [review] [checked-in] Proposed patch (trunk rebase 2010-08-10). backed out in http://hg.mozilla.org/mozilla-central/rev/5f699108f3cf
Attachment #464580 - Attachment description: [checked-in] Proposed patch (trunk rebase 2010-08-10). → [backed-out] Proposed patch (trunk rebase 2010-08-10).
this was probably not the culprit, but after backing one patch out, we thought it best to back the whole set out for analysis.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
(In reply to comment #8) > this was probably not the culprit, but after backing one patch out, we thought > it best to back the whole set out for analysis. I'm almost certain it's not the cause of any leaks or CSS regressions: it's just copying one file from winstripe/ to gnomestripe/.
Comment on attachment 464580 [details] [diff] [review] [checked-in] Proposed patch (trunk rebase 2010-08-10). http://hg.mozilla.org/mozilla-central/rev/7aec6a6c9803
Attachment #464580 - Attachment description: [backed-out] Proposed patch (trunk rebase 2010-08-10). → [checked-in] Proposed patch (trunk rebase 2010-08-10).
Status: REOPENED → RESOLVED
Closed: 15 years ago → 15 years ago
Resolution: --- → FIXED
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: