Closed Bug 584611 Opened 9 years ago Closed 9 years ago

Test detection is not correct

Categories

(Testing :: Mochitest, defect)

x86
All
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: cmtalbert, Assigned: cmtalbert)

References

Details

Attachments

(1 file)

In mochitest, we tell people that mochitests should start with test_.  The actual truth is that we match anything with a test_ in it.

This is broken, and it breaks our ability to upload existing test frameworks into mochitest from outside groups as they have mini-manifests for their files called 'webgl_test_list.txt' for instance.  We should make mochitest conform to the docs that we've written and only treat files that start with test_ as tests.

patch upcoming.
Attached patch testdetection v1Splinter Review
This should fix it.  Need to test on windows.  I'm building windows now.  We should also grep through the mochitest/tests and chrome/tests and browserchrome/tests and a11y/tests and make sure that there is nothing depending on matching indexof('test_') since those will now basically be skipped and will be invisible failures as a result of this patch.
Assignee: nobody → ctalbert
Status: NEW → ASSIGNED
Attachment #463635 - Flags: review?(jmaher)
I have verified that we have parity with the old way in discovering tests.  I verified mochitest-plain/chrome/a11y/browser-chrome.

I have this up on try server.  If it passes, we will work on checking this in.
Comment on attachment 463635 [details] [diff] [review]
testdetection v1

this is a minor change.  I verified this works on try server and that we are not skipping any tests that we had before.
Attachment #463635 - Flags: review?(jmaher) → review+
Landed: http://hg.mozilla.org/mozilla-central/rev/b3e34d6dbc4b
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Backed out: http://hg.mozilla.org/mozilla-central/rev/4192ba38ebee
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Blocks: 582053
Ok, landing again.  This went green a couple of rounds on the try server, so crossing fingers..
http://hg.mozilla.org/mozilla-central/rev/5fb749171234
Status: REOPENED → RESOLVED
Closed: 9 years ago9 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.