584628 - Last URL I loaded in regular browsing showing in Private Browsing Mode

Status: RESOLVED INVALID

(Firefox :: Private Browsing, defect)

Description

[Marcia Knous [:marcia]]

Attachment: Screenshot of issue

Seen while testing Mozilla/5.0 (Windows; Windows NT 6.1; rv:2.0b3) Gecko/20100804 Firefox/4.0b3

STR:
1. Load a fresh profile, no extensions.
2. Load a few sites in reg browsing mode
3. Switch to Private Browsing mode.

Observe attached screenshot. the last site that I had loaded in regular session shows. When entering PB mode the URL bar should show no sites.

Comment 1

[Marcia Knous [:marcia]]

Private browsing also exhibited some other strange behavior while I was testing. Will probe a bit more.

Comment 2

[(no longer active)]

Can you reproduce this?

Comment 3

[Marcia Knous [:marcia]]

Will try as soon as I can restore power to my Windows 7 laptop. I have not been able to reproduce this using the Mac B3 build.

One thing I forgot to include in the STR is that I enabled the Bookmarks menu when I was playing around with the feature.

(In reply to comment #2)
> Can you reproduce this?

Comment 4

[(no longer active)]

If you can get it to reproduce, can you please try to find a regression range?  I suspect that this is a real bug, but finding the cause is going to be tricky, given the recent spew of UI changes landed, so a regression range would be much helpful.  Thanks!

Comment 5

[Marcia Knous [:marcia]]

Will do. Also FYI note Paul's Bug 584713, which may not be related to this one but maps a bit better to the behavior I was seeing in PB mode certain things related to tabs were not working correctly.

(In reply to comment #4)
> If you can get it to reproduce, can you please try to find a regression range? 
> I suspect that this is a real bug, but finding the cause is going to be tricky,
> given the recent spew of UI changes landed, so a regression range would be much
> helpful.  Thanks!

Comment 6

[Marcia Knous [:marcia]]

Ehsan: Here are some errors in the console:

Error: Exception thrown while processing the private browsing mode change request: [Exception... "'[JavaScript Error: "tab is null" {file: "chrome://browser/content/tabbrowser.xml" line: 2315}]' when calling method: [nsISessionStore::setBrowserState]"  nsresult: "0x80570021 (NS_ERROR_XPC_JAVASCRIPT_ERROR_WITH_DETAILS)"  location: "JS frame :: file:///C:/Program%20Files/Mozilla%20Firefox%204.0%20Beta%203/components/nsPrivateBrowsingService.js :: PBS__onBeforePrivateBrowsingModeChange :: line 160"  data: yes]
Source File: file:///C:/Program%20Files/Mozilla%20Firefox%204.0%20Beta%203/components/nsPrivateBrowsingService.js
Line: 485

Error: Exception thrown while processing the private browsing mode change request: [Exception... "'[JavaScript Error: "tabbrowser.selectedTab is null" {file: "file:///C:/Program%20Files/Mozilla%20Firefox%204.0%20Beta%203/components/nsSessionStore.js" line: 1929}]' when calling method: [nsISessionStore::setBrowserState]"  nsresult: "0x80570021 (NS_ERROR_XPC_JAVASCRIPT_ERROR_WITH_DETAILS)"  location: "JS frame :: file:///C:/Program%20Files/Mozilla%20Firefox%204.0%20Beta%203/components/nsPrivateBrowsingService.js :: PBS__onBeforePrivateBrowsingModeChange :: line 160"  data: yes]
Source File: file:///C:/Program%20Files/Mozilla%20Firefox%204.0%20Beta%203/components/nsPrivateBrowsingService.js
Line: 485

this happened after I enabled and then disabled the Web Console. After I disable the Web Console I get the following consistent behavior in PB mode:

1. Each new tab I open up has the URL of the previous tab.
2. When I try to load a new URL in that tab and press enter, nothing happens The "Go to Web Site") is not enabled.

Comment 7

[Marcia Knous [:marcia]]

I will try hunt down a regression range but this might very well be related to enabling and disabling the web console.

Comment 8

[Marcia Knous [:marcia]]

I was not able to reproduce this bug using the Windows 7 machine in the QA lab and the b3 build. I made a comment in Bug 584713 to see if I should dupe this bug to that one.

Comment 9

[(no longer active)]

(In reply to comment #7)
> I will try hunt down a regression range but this might very well be related to
> enabling and disabling the web console.

You mean that you disabled and enabled the console at some point in the STR?

Comment 10

[Johnathan Nightingale [:johnath]]

Doesn't block without more details, would like to see it hunted, fixed though.

Comment 11

[Jon Erland Madsen]

I think this behaviour might be connected to private sessions: If you were in private mode during your session, your last opened pages are displayed next time you start Firefox, not your chosen start page. The pages you read while in private mode are not displayed, but the pages you visited before and after setting the browser in private mode.

1) Use Firefox in normal mode. Open some pages in different tabs.
2) Switch to private mode. Open a couple of pages.
3) Switch back to normal mode. Close all tabs.
4) Close Firefox normally.

When you start up again, the last tabs are showing, not your chosen start page.

Comment 12

[juan becerra [:juanb]]

Using the latest nightly, and a fresh profile, I am not able to reproduce this problem. I tried Win 7 and Mac OS X 10.6.5.

Comment 13

[(no longer active)]

The behavior in comment 11 is the expected behavior.

Marcia, can you reproduce this?

Comment 14

[Jon Erland Madsen]

(In reply to comment #13)
> The behavior in comment 11 is the expected behavior.
> 
> Marcia, can you reproduce this?

I don't want to quarrel, but is it really expected that your designated, chosen start page should not be displayed when Firefox is closed normally and started normally again?

Comment 15

[(no longer active)]

(In reply to comment #14)
> (In reply to comment #13)
> > The behavior in comment 11 is the expected behavior.
> > 
> > Marcia, can you reproduce this?
> 
> I don't want to quarrel, but is it really expected that your designated, chosen
> start page should not be displayed when Firefox is closed normally and started
> normally again?

Yes.  It's working as it was designed to.  Bug 596590 has been filed for changing this behavior, though.

Comment 16

[Drowsy]

There is a privacy risk associated with this bug.

Repro:
1. Open Firefox (4.01) and set homepage to anything other than facebook.com
2. Go to facebook.com. Log into facebook with "keep me logged in" unchecked
3. Close Firefox. Confirm Firefox exited in task manager
4. Open Firefox. Go back to facebook.com. You should *not* be logged into facebook (because of checkbox)
5. Log into facebook again with "keep me logged in" unchecked
6. Close Firefox. Confirm Firefox exited in task manager
7. Open Firefox in Private mode (either by jumplist or command line -private)
8. Close Firefox. Confirm Firefox exited in task manager
9. Open Firefox

Expected: Firefox should open in the homepage
Result: Firefox will open to a logged in facebook account


Non-crash session is being saved somehow for last open page of Firefox and is reconstituted when a user exits private browsing.

Comment 17

[Kanchan Kumari QA]

I can't reproduce reporter's issue and comment 16 on Windows7 with the latest release of Firefox. Can you please retest on the latest release and with the fresh profile. Please let us know your finding.

Ehsan, is this bug ok to close?

Comment 18

[(no longer active)]

This bug became moot when we switched to per-window private browsing (bug 463027)