584678 - nsAsyncRedirectVerifyHelper.cpp compilation failure

Status: RESOLVED FIXED

(Core :: Networking, defect)

Description

[Jacek Caban]

Attachment: fix v1.0

I get a compilation failure on mingw (GCC 4.5.0, I expect it to not be specific to mingw):

/home/jacek/mozilla-build/mozilla-central/netwerk/base/src/nsAsyncRedirectVerifyHelper.cpp: In member function 'void nsAsyncRedirectVerifyHelper::ExplicitCallback(nsresult)':
/home/jacek/mozilla-build/mozilla-central/netwerk/base/src/nsAsyncRedirectVerifyHelper.cpp:202:9: error: cannot pass objects of non-trivially-copyable type 'class nsCOMPtr<nsIAsyncVerifyRedirectCallback>' through '...'
/home/jacek/mozilla-build/mozilla-central/netwerk/base/src/nsAsyncRedirectVerifyHelper.cpp:202:9: error: cannot pass objects of non-trivially-copyable type 'class nsCOMPtr<nsIThread>' through '...'


The fix (attached) is to pass raw pointer instead of nsCOMPtr to LOG.

Comment 1

[Ashley Bischoff (blog at handcoding.com)]

This is a bit of a guess, but might bug 584418 be a dupe of this?

Comment 2

[Jacek Caban]

(In reply to comment #1)
> This is a bit of a guess, but might bug 584418 be a dupe of this?

It doesn't seem to be related.

Comment 3

[Johnny Stenback (:jst)]

Comment on attachment 463122 [details] [diff] [review]
fix v1.0

Yup, we want this. Thanks for the patch!

Comment 4

[Jacek Caban]

Thanks for the review. Pushed to m-c:

http://hg.mozilla.org/mozilla-central/rev/efcbc31708f1