584695 - crash [@ nsEudoraMac::IterateMailDir(nsIFile*, nsISupportsArray*, nsIImportService*)]

Status: RESOLVED WONTFIX

(MailNews Core :: Import, defect)

Description

[Wayne Mery (:wsmwk)]

crash [@ nsEudoraMac::IterateMailDir(nsIFile*, nsISupportsArray*, nsIImportService*)] 

bp-7082b699-60e5-4639-a987-d1bfb2100801  v3.1.1
0	thunderbird-bin	nsEudoraMac::IterateMailDir	 mailnews/import/eudora/src/nsEudoraMac.cpp:314
1	thunderbird-bin	nsEudoraMac::IterateMailDir	mailnews/import/eudora/src/nsEudoraMac.cpp:281
2	thunderbird-bin	nsEudoraMac::IterateMailDir	mailnews/import/eudora/src/nsEudoraMac.cpp:281
3	thunderbird-bin	nsEudoraMac::IterateMailDir	mailnews/import/eudora/src/nsEudoraMac.cpp:281
4	thunderbird-bin	nsEudoraMac::IterateMailDir	mailnews/import/eudora/src/nsEudoraMac.cpp:281
5	thunderbird-bin	nsEudoraMac::FindMailboxes	mailnews/import/eudora/src/nsEudoraMac.cpp:281
6	thunderbird-bin	ImportEudoraMailImpl::FindMailboxes	mailnews/import/eudora/src/nsEudoraImport.cpp:479
7	thunderbird-bin	nsImportGenericMail::WantsProgress	mailnews/import/src/nsImportMail.cpp:391

Comment 1

[Ludovic Hirlimann [:Usul]]

Jeff could you have a look please ?

Comment 2

[Wayne Mery (:wsmwk)]

bp-d79dc714-58ec-4e86-951e-c4be42110506
EXC_BAD_ACCESS / KERN_PROTECTION_FAILURE
0x0
0	thunderbird-bin	nsEudoraMac::IterateMailDir	mailnews/import/eudora/src/nsEudoraMac.cpp:314
1	thunderbird-bin	nsEudoraMac::IterateMailDir	mailnews/import/eudora/src/nsEudoraMac.cpp:281
2	thunderbird-bin	nsEudoraMac::IterateMailDir	mailnews/import/eudora/src/nsEudoraMac.cpp:281
3	thunderbird-bin	nsEudoraMac::IterateMailDir	mailnews/import/eudora/src/nsEudoraMac.cpp:281
4	thunderbird-bin	nsEudoraMac::IterateMailDir	mailnews/import/eudora/src/nsEudoraMac.cpp:281
5	thunderbird-bin	nsEudoraMac::IterateMailDir	mailnews/import/eudora/src/nsEudoraMac.cpp:281
6	thunderbird-bin	nsEudoraMac::IterateMailDir	mailnews/import/eudora/src/nsEudoraMac.cpp:281
7	thunderbird-bin	nsEudoraMac::IterateMailDir	mailnews/import/eudora/src/nsEudoraMac.cpp:281
8	thunderbird-bin	nsEudoraMac::FindMailboxes	mailnews/import/eudora/src/nsEudoraMac.cpp:281
9	thunderbird-bin	ImportEudoraMailImpl::FindMailboxes	mailnews/import/eudora/src/nsEudoraImport.cpp:479
10	thunderbird-bin	nsImportGenericMail::WantsProgress	mailnews/import/src/nsImportMail.cpp:391

Comment 3

[:aceman]

Wayne, this bug seems to predate Thunderbirds maildir implementation. Does it really block bug 845952? Isn't this just about importing Eudora's maildir store into TB (whatever store it has)?

Comment 4

[Wayne Mery (:wsmwk)]

still occurs for current versions. examples
bp-80595ae2-1ffe-4846-a896-42c422140120
bp-c06c6bbe-fb96-4c27-a5ce-b5c232131007

0	XUL	nsEudoraMac::IterateMailDir(nsIFile*, nsISupportsArray*, nsIImportService*)	mailnews/import/eudora/src/nsEudoraMac.cpp
1	XUL	nsEudoraMac::IterateMailDir(nsIFile*, nsISupportsArray*, nsIImportService*)	mailnews/import/eudora/src/nsEudoraMac.cpp
2	XUL	nsEudoraMac::IterateMailDir(nsIFile*, nsISupportsArray*, nsIImportService*)	mailnews/import/eudora/src/nsEudoraMac.cpp
3	XUL	nsEudoraMac::IterateMailDir(nsIFile*, nsISupportsArray*, nsIImportService*)	mailnews/import/eudora/src/nsEudoraMac.cpp
4	XUL	nsEudoraMac::IterateMailDir(nsIFile*, nsISupportsArray*, nsIImportService*)	mailnews/import/eudora/src/nsEudoraMac.cpp
5	XUL	nsEudoraMac::IterateMailDir(nsIFile*, nsISupportsArray*, nsIImportService*)	mailnews/import/eudora/src/nsEudoraMac.cpp
6	XUL	nsEudoraMac::IterateMailDir(nsIFile*, nsISupportsArray*, nsIImportService*)	mailnews/import/eudora/src/nsEudoraMac.cpp
7	XUL	nsEudoraMac::IterateMailDir(nsIFile*, nsISupportsArray*, nsIImportService*)	mailnews/import/eudora/src/nsEudoraMac.cpp
8	XUL	nsEudoraMac::FindMailboxes(nsIFile*, nsISupportsArray**)	mailnews/import/eudora/src/nsEudoraMac.cpp
9	XUL	ImportEudoraMailImpl::FindMailboxes(nsIFile*, nsISupportsArray**)	mailnews/import/eudora/src/nsEudoraImport.cpp
10	XUL	nsImportGenericMail::WantsProgress(bool*)	mailnews/import/src/nsImportMail.cpp
11	XUL	NS_InvokeByIndex	xpcom/reflect/xptcall/src/md/unix/xptcinvoke_x86_64_unix.cpp 

Chronologically...

hiikezoe@11446 426 NS_IMETHODIMP ImportEudoraMailImpl::FindMailboxes(nsIFile *pLoc, nsISupportsArray **ppArray)
hg@0 427 {
mconley@13187 428 NS_PRECONDITION(pLoc != nullptr, "null ptr");
mconley@13187 429 NS_PRECONDITION(ppArray != nullptr, "null ptr");
hg@0 430 if (!pLoc || !ppArray)
hg@0 431 return NS_ERROR_NULL_POINTER;
hg@0 432
mwu@9431 433 bool exists = false;
hiikezoe@11446 434 nsresult rv = pLoc->Exists(&exists);
hiikezoe@11446 435 if (NS_FAILED(rv) || !exists)
hiikezoe@11446 436 return NS_ERROR_FAILURE;
hg@0 437
hiikezoe@11446 438 rv = m_eudora.FindMailboxes(pLoc, ppArray); 

several iterations of 
hiikezoe@11446 235 nsresult nsEudoraMac::ScanMailDir(nsIFile *pFolder, nsISupportsArray *pArray, nsIImportService *pImport)
hg@0 236 {
hg@0 238 // On Windows, we look for a descmap file but on Mac we just iterate
hg@0 239 // the directory
hg@0 241 m_depth++;
hg@0 242
hiikezoe@11446 243 nsresult rv = IterateMailDir(pFolder, pArray, pImport); 

hiikezoe@11446 250 nsresult nsEudoraMac::IterateMailDir(nsIFile *pFolder, nsISupportsArray *pArray, nsIImportService *pImport)
hg@0 251 {
mwu@9431 252 bool hasMore;
hg@0 253 nsCOMPtr<nsISimpleEnumerator> directoryEnumerator;
hg@0 254 nsresult rv = pFolder->GetDirectoryEntries(getter_AddRefs(directoryEnumerator));
hg@0 255 NS_ENSURE_SUCCESS(rv, rv);
hg@0 256
hg@0 257 directoryEnumerator->HasMoreElements(&hasMore);
hg@0 258
hg@0 259 while (hasMore && NS_SUCCEEDED(rv))
hg@0 260 {
hg@0 261 nsCOMPtr<nsISupports> aSupport;
hg@0 262 rv = directoryEnumerator->GetNext(getter_AddRefs(aSupport));
geoff@12584 263 nsCOMPtr<nsIFile> entry(do_QueryInterface(aSupport, &rv));
hg@0 264 directoryEnumerator->HasMoreElements(&hasMore);
hg@0 265
mwu@9431 266 bool isFolder;
mwu@9431 267 bool isFile;
hg@0 268 nsCString fName;
hg@0 269 nsCString ext;
hg@0 270 nsCString name;
hg@0 271 OSType type;
hg@0 272 OSType creator;
hg@0 273
bugzilla@10318 274 isFolder = false;
bugzilla@10318 275 isFile = false;
hiikezoe@11446 276 rv = entry->IsDirectory(&isFolder);

Comment 5

[:aceman]

I think Eudora importer was removed from mailnews.