Closed
Bug 584785
Opened 15 years ago
Closed 15 years ago
Share link should restrict based on protocol?
Categories
(Firefox for Android Graveyard :: General, defect)
Firefox for Android Graveyard
General
Tracking
(fennec2.0b1+)
VERIFIED
FIXED
Tracking | Status | |
---|---|---|
fennec | 2.0b1+ | --- |
People
(Reporter: stechz, Assigned: mbrubeck)
Details
(Whiteboard: [fennec-checkin-posta1])
Attachments
(1 file, 1 obsolete file)
5.59 KB,
patch
|
mfinkle
:
review+
|
Details | Diff | Splinter Review |
I just got a "share link" for javascript:void(0). We should probably restrict sharing to telephone numbers and http(s)/ftp?
Updated•15 years ago
|
tracking-fennec: ? → 2.0b1+
Comment 2•15 years ago
|
||
javascript:void(0) may be an exception to the rule. I can see wanting to share a bookmarklet that uses javascript:. mailto:, aim:, irc: etc. all seem "sharable".
Comment 3•15 years ago
|
||
other types to consider
- about:
- file://
- chrome:// ?
Assignee | ||
Updated•15 years ago
|
Assignee: nobody → mbrubeck
Assignee | ||
Comment 4•15 years ago
|
||
These are the most common URIs we use that are probably not useful to "share".
Attachment #466940 -
Flags: review?(mark.finkle)
Updated•15 years ago
|
Attachment #466940 -
Flags: review?(mark.finkle) → review+
Assignee | ||
Updated•15 years ago
|
Status: NEW → ASSIGNED
Whiteboard: [fennec-checkin-posta1]
Reporter | ||
Comment 5•15 years ago
|
||
There's no way to tell between a Javascript bookmarklet and some script that isn't meant to be saved. If you want to share a bookmarklet, you can link the page that gives you the bookmarklet anyways.
Comment 6•15 years ago
|
||
case - when we do "share link" for the "Get Firefox Sync" and "Get Addons" on the about:firstrun page, and share it via email, it shows javascript:loadsync() and javascript:loadaddons() respectively in the email.
Assignee | ||
Comment 7•15 years ago
|
||
I think we have a consensus that javascript: URIs should be excluded too.
Attachment #466940 -
Attachment is obsolete: true
Attachment #467827 -
Flags: review?(mark.finkle)
Updated•15 years ago
|
Attachment #467827 -
Flags: review?(mark.finkle) → review+
Comment 8•15 years ago
|
||
While you're at it, maybe add resource:// too.
Assignee | ||
Comment 9•15 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Updated•15 years ago
|
Flags: in-testsuite?
Flags: in-litmus?
Comment 10•15 years ago
|
||
Verified fix on
Mozilla/5.0 (X11; U; Linux armv7l; en-US; rv:2.0b4pre) Gecko/201000901 Namoroka/4.04pre Fennec/2.0a1pre
Mozilla/5.0 (Android; Linux armv7l; rv:2.0b5pre) Gecko/20100901 Firefox/4.0b5pre Fennec/2.0a1pre
Status: RESOLVED → VERIFIED
Comment 12•15 years ago
|
||
(In reply to comment #11)
> Assigning to self to create a litmus testcase.
The assignee field is only for the developer who wrote the patch.
Assignee: tchung → mbrubeck
Comment 13•15 years ago
|
||
We talked about this on irc with blassey and ted. We're experimenting.
Updated•15 years ago
|
Flags: in-litmus? → in-litmus?(tchung)
Comment 14•15 years ago
|
||
(In reply to comment #13)
> We talked about this on irc with blassey and ted. We're experimenting.
and I told you what Reed just said
Comment 15•15 years ago
|
||
Flags: in-litmus?(tchung) → in-litmus+
You need to log in
before you can comment on or make changes to this bug.
Description
•