Closed Bug 584785 Opened 15 years ago Closed 15 years ago

Share link should restrict based on protocol?

Categories

(Firefox for Android Graveyard :: General, defect)

defect
Not set
normal

Tracking

(fennec2.0b1+)

VERIFIED FIXED
Tracking Status
fennec 2.0b1+ ---

People

(Reporter: stechz, Assigned: mbrubeck)

Details

(Whiteboard: [fennec-checkin-posta1])

Attachments

(1 file, 1 obsolete file)

I just got a "share link" for javascript:void(0). We should probably restrict sharing to telephone numbers and http(s)/ftp?
flagging for fennec 2.0 to get on triage plate
tracking-fennec: --- → ?
tracking-fennec: ? → 2.0b1+
javascript:void(0) may be an exception to the rule. I can see wanting to share a bookmarklet that uses javascript:. mailto:, aim:, irc: etc. all seem "sharable".
other types to consider - about: - file:// - chrome:// ?
Assignee: nobody → mbrubeck
These are the most common URIs we use that are probably not useful to "share".
Attachment #466940 - Flags: review?(mark.finkle)
Attachment #466940 - Flags: review?(mark.finkle) → review+
Status: NEW → ASSIGNED
Whiteboard: [fennec-checkin-posta1]
There's no way to tell between a Javascript bookmarklet and some script that isn't meant to be saved. If you want to share a bookmarklet, you can link the page that gives you the bookmarklet anyways.
case - when we do "share link" for the "Get Firefox Sync" and "Get Addons" on the about:firstrun page, and share it via email, it shows javascript:loadsync() and javascript:loadaddons() respectively in the email.
I think we have a consensus that javascript: URIs should be excluded too.
Attachment #466940 - Attachment is obsolete: true
Attachment #467827 - Flags: review?(mark.finkle)
Attachment #467827 - Flags: review?(mark.finkle) → review+
While you're at it, maybe add resource:// too.
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Flags: in-testsuite?
Flags: in-litmus?
Verified fix on Mozilla/5.0 (X11; U; Linux armv7l; en-US; rv:2.0b4pre) Gecko/201000901 Namoroka/4.04pre Fennec/2.0a1pre Mozilla/5.0 (Android; Linux armv7l; rv:2.0b5pre) Gecko/20100901 Firefox/4.0b5pre Fennec/2.0a1pre
Status: RESOLVED → VERIFIED
Assigning to self to create a litmus testcase.
Assignee: mbrubeck → tchung
(In reply to comment #11) > Assigning to self to create a litmus testcase. The assignee field is only for the developer who wrote the patch.
Assignee: tchung → mbrubeck
We talked about this on irc with blassey and ted. We're experimenting.
Flags: in-litmus? → in-litmus?(tchung)
(In reply to comment #13) > We talked about this on irc with blassey and ted. We're experimenting. and I told you what Reed just said
Flags: in-litmus?(tchung) → in-litmus+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: