584811 - Date.prototype.toJSON isn't to spec

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Jeff Walden [:Waldo]]

Per ES5 it is not merely a clone of toISOString; it actually does something like the weirdness of Array.prototype.toString in that it does some checks, then delegates to |this.toISOString|.

Comment 1

[Jeff Walden [:Waldo]]

(discovered via the MS ES5 tests, somewhat)

Comment 2

[Jeff Walden [:Waldo]]

Attachment: Patch and tests

Comment 3

[Robert Sayre]

Comment on attachment 465528 [details] [diff] [review]
Patch and tests

Righteous.

>+
>+    if (!Invoke(cx, args, 0))
>+        return false;
>+    *vp = args.rval();
>+    return true;

I think the style police want a blank line before and after the assignment to *vp.

Comment 4

[Brendan Eich [:brendan]]

(In reply to comment #3)
> Comment on attachment 465528 [details] [diff] [review]
> Patch and tests
> 
> Righteous.
> 
> >+
> >+    if (!Invoke(cx, args, 0))
> >+        return false;
> >+    *vp = args.rval();
> >+    return true;
> 
> I think the style police want a blank line before and after the assignment to
> *vp.

No -- who ever said so? Bad cop, no donut.

/be

Comment 5

[Jeff Walden [:Waldo]]

http://hg.mozilla.org/tracemonkey/rev/2573e884e17b

I'm pretty sure I've seen both styles for the blank-line nit, or at least I have not seen one so often that it has consciously risen in my mind to the level of a gold standard.  Killed the blank line here, tho.

Comment 6

[Robert Sayre]

http://hg.mozilla.org/mozilla-central/rev/2573e884e17b

Comment 7

[Eric Shepherd [:sheppy]]

Added:

https://developer.mozilla.org/en/JavaScript/Reference/Global_Objects/Date/toJSON

Listed on:

https://developer.mozilla.org/en/JavaScript/Reference/Global_Objects/Date/prototype

And mentioned on:

https://developer.mozilla.org/en/JavaScript/New_in_JavaScript/1.8.5