Closed Bug 584912 Opened 14 years ago Closed 14 years ago

Use after free in jsd_NewThreadState.

Categories

(Core :: JavaScript Engine, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: adrake, Assigned: adrake)

Details

(Whiteboard: fixed-in-tracemonkey)

Attachments

(1 file)

The following lines occur in jsd_stak.c on line 151:

jsd_DestroyThreadState(jsdc, jsdthreadstate);
JS_EndRequest(jsdthreadstate->context);

jsd_DestroyThreadState free()s jsdthreadstate which is then immediately used. Patch forthcoming.
Assignee: nobody → adrake
Status: NEW → ASSIGNED
r=me
Attached patch PatchSplinter Review
Fix.
Attachment #463462 - Flags: review?(timeless)
Attachment #463462 - Flags: approval2.0?
Comment on attachment 463462 [details] [diff] [review]
Patch

Updated r? to reflect above comment.
Attachment #463462 - Flags: review?(timeless) → review+
Attachment #463462 - Flags: approval2.0? → approval2.0+
http://hg.mozilla.org/tracemonkey/rev/bbfce6d8415d
Whiteboard: fixed-in-tracemonkey
http://hg.mozilla.org/mozilla-central/rev/bbfce6d8415d
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Component: JavaScript Debugging/Profiling APIs → JavaScript Engine
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: