Closed Bug 584945 Opened 12 years ago Closed 12 years ago

add PR_STATIC_ASSERTs for char sizes

Categories

(Core :: XPCOM, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla2.0b4

People

(Reporter: dbaron, Assigned: dbaron)

Details

Attachments

(1 file, 1 obsolete file)

Attached patch patch (obsolete) — Splinter Review
I was in a not-very-trusting mood, and decided to add a few PR_STATIC_ASSERTs that might catch porting errors or other fun-with-wchar_t-and-friends.
Attachment #463424 - Flags: review?(benjamin)
Oh, and the idea originated while reading bug 508905.
Comment on attachment 463424 [details] [diff] [review]
patch

Can we put this somewhere more public, like nsString.h, so it can catch flag issues across translation units?
Attachment #463424 - Flags: review?(benjamin) → review-
Attached patch patchSplinter Review
Attachment #463424 - Attachment is obsolete: true
Attachment #464441 - Flags: review?(benjamin)
Attachment #464441 - Flags: review?(benjamin) → review+
http://hg.mozilla.org/mozilla-central/rev/058caf257ad0
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla2.0b4
Component: String → XPCOM
You need to log in before you can comment on or make changes to this bug.