Make simplejson available in python 2.5.x installation for linux and macosx

RESOLVED FIXED

Status

Release Engineering
General
P2
normal
RESOLVED FIXED
8 years ago
5 years ago

People

(Reporter: rail, Assigned: rail)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [buildslaves][puppet])

Attachments

(5 attachments)

(Assignee)

Description

8 years ago
Created attachment 463429 [details]
simplejson RPM spec

Bug 555205 requires json (available in Python 2.6) or simplejson for 2.5.1.

Default Python used for builds is 2.5.1 but simplejson is not available on linux{,64} and macosx{,64} platforms.

catlee suggested to install simplejson to 2.5.1, what IMO should be done by separate RPM/DMG packages.

Please see attached RPM specs (setuptools is a build time requirement, we don't need it to be installed on the build slaves).
Attachment #463429 - Flags: review?(bhearsum)
(Assignee)

Comment 1

8 years ago
Created attachment 463430 [details]
setuptools RPM spec
Attachment #463430 - Flags: review?(bhearsum)
(Assignee)

Comment 2

8 years ago
TODO: DMG build instructions and puppet manifests.
(Assignee)

Comment 3

8 years ago
Created attachment 464003 [details]
setup-tools-create-dmg.sh

setup-tools-create-dmg.sh creates a DMG pkg for darwin9 machines and uses /tools/python as a default python. This packages only needed for creating simplejson package and there is no need to install it on every machine.
Attachment #464003 - Flags: review?(bhearsum)
(Assignee)

Comment 4

8 years ago
Created attachment 464004 [details]
simplejson-create-dmg.sh

simplejson-create-dmg.sh creates simplejson DMG using /tools/python hierarchy (not versioned).
Attachment #464004 - Flags: review?(bhearsum)
(Assignee)

Updated

8 years ago
Summary: Make simlejson available in python 2.5.1 installation for linux and macosx → Make simlejson available in python 2.5.x installation for linux and macosx
(Assignee)

Comment 5

8 years ago
Created attachment 464005 [details] [diff] [review]
Puppet manifest

simplejson-2.1.1-py25.dmg is for darwin9 machines only. Darwin10 machines have 2.6.4 with json module afaik.
Attachment #464005 - Flags: review?(bhearsum)
Comment on attachment 463430 [details]
setuptools RPM spec

Mostly copied from upstream, which is great, looks fine.
Attachment #463430 - Flags: review?(bhearsum) → review+
Attachment #463429 - Flags: review?(bhearsum) → review+
Comment on attachment 464003 [details]
setup-tools-create-dmg.sh

Why does this script install it, too?
Attachment #464005 - Flags: review?(bhearsum) → review+
(Assignee)

Comment 8

8 years ago
(In reply to comment #7)
> Why does this script install it, too?

Just to record every step I've done on the slave. We're going to use only the generated DMG files in production.
Attachment #464003 - Flags: review?(bhearsum) → review+
Attachment #464004 - Flags: review?(bhearsum) → review+
(Assignee)

Updated

8 years ago
Attachment #463430 - Flags: checked-in? → checked-in+
(Assignee)

Comment 12

8 years ago
Staging run was successful for the targeted 3 platforms. I copied the binaries (excluding setuptools) to /N/production, so the manifest patch is ready for deployment.
(Assignee)

Updated

8 years ago
Blocks: 585605
(Assignee)

Updated

8 years ago
Summary: Make simlejson available in python 2.5.x installation for linux and macosx → Make simplejson available in python 2.5.x installation for linux and macosx
(Assignee)

Comment 13

8 years ago
Comment on attachment 464005 [details] [diff] [review]
Puppet manifest

http://hg.mozilla.org/build/puppet-manifests/rev/00b3f88d1ec0

mpt-production-puppet, mv-production-puppet and staging-puppet servers are updated as well.
Attachment #464005 - Flags: checked-in+
No longer blocks: 585605
(Assignee)

Comment 14

8 years ago
simplejson is available as expected on randomly checked linux, linux64 and darwin9 build slaves.
Status: NEW → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
Product: mozilla.org → Release Engineering
You need to log in before you can comment on or make changes to this bug.