584956 - Quick search for multi-state fields with dash in the name is broken

Status: RESOLVED FIXED

(bugzilla.mozilla.org :: General, defect)

Description

[Mark Banner (:standard8)]

I have multiple queries using the quick search format, e.g. https://bugzilla.mozilla.org/buglist.cgi?quicksearch=ALL%20blocking-thunderbird3.1:.2+%20-status-thunderbird3.1:fixed%20-whiteboard:non-code&order=map_assigned_to.login_name,bugs.bug_id

They are all returning similar errors:

================
There is a problem with your search:

blocking%2Dthunderbird3.1 is not a valid field name.

status%2Dthunderbird3.1 is not a valid field name.

The legal field names are listed here.
================

Quick searches for blocking1.9.1 work fine.

The Thunderbird searches used to work not more than 2 or 3 days ago. This breaks a lot of my release tracking queries.

Comment 1

[Dave Miller [:justdave]]

I suspect this change:   (picked up with the 3.6.2 update earlier tonight)

http://bzr.mozilla.org/bmo/3.6/revision/7170#Bugzilla/Search/Quicksearch.pm

But isn't that just making a subroutine that does what it was already doing?  How did that break it?

Comment 2

[Dave Miller [:justdave]]

Oh, I see it... line 562...

Comment 3

[Dave Miller [:justdave]]

Upstream regression from bug 553884...

Comment 4

[Dave Miller [:justdave]]

I temporarily backed out the patch from bug 553884 on b.m.o until this is sorted.

Comment 5

[Max Kanat-Alexander]

In standard Bugzilla, field names may not have dashes in them. So this would be a bmo-specific problem.

Comment 6

[Frédéric Buclin]

Ah, right, I just checked that. :) Good to know.

Comment 7

[Reed Loden [:reed]]

>--- Bugzilla/Search/Quicksearch.pm	23 Jul 2010 02:03:14 -0000	1.38
>+++ Bugzilla/Search/Quicksearch.pm	2 Aug 2010 01:56:10 -0000
>@@ -517,6 +517,7 @@ sub splitString {
>         # as it has a special meaning. Strings which start with
>         # "+" must be quoted.
>         s/(?<!^)\+/%2B/g;
>+        s/(?<!^)\-/%2D/g;
>         # Remove quotes
>         s/"//g;
>     }

The comment talks about "which start with"... If the regex actually did that instead of matching any hyphen in the field name, then having hyphens in field names (like bmo does) wouldn't be causing a problem.

Comment 8

[Reed Loden [:reed]]

The patch for bug 585028 should fix this.