Closed Bug 584970 Opened 14 years ago Closed 8 years ago

mark deprecated necko interfaces and methods with [deprecated]

Categories

(Core :: Networking, defect)

x86
macOS
defect
Not set
normal

Tracking

()

RESOLVED INCOMPLETE

People

(Reporter: timeless, Assigned: timeless)

References

Details

(Whiteboard: not-ready)

Attachments

(1 file, 1 obsolete file)

We have a way to mark interfaces and methods as deprecated which some compilers
are able to use to complain about deprecation. This bug is for sprinkling that
marker into necko idl files.

Please note that at this time we only properly trigger these compile time
warnings with msvc (bug 584953 covers the fixing the gcc side).
Attached patch proposal (obsolete) — Splinter Review
Assignee: nobody → timeless
Status: NEW → ASSIGNED
Attachment #463466 - Flags: review?(cbiesinger)
Comment on attachment 463466 [details] [diff] [review]
proposal

I'm not sure you should change nsIAuthPrompt at this case, because *2 is not necessarily a full replacement (it requires a channel).
Attachment #463466 - Flags: review?(cbiesinger) → review+
Attachment #463466 - Attachment is obsolete: true
Attachment #463525 - Flags: review+
Attachment #463525 - Flags: approval2.0?
Attachment #463525 - Flags: approval2.0? → approval2.0+
Depends on: 578478
No longer depends on: 584960
Comment on attachment 463525 [details] [diff] [review]
without nsIAuthPrompt

Per bug 584998 comment 2 this doesn't work as expected yet
Attachment #463525 - Flags: approval2.0+ → approval2.0-
This will fail too since it adds a [deprecated] interface.
Whiteboard: not-ready
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → INCOMPLETE
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: