584995 - waitForFocus makes test analysis lie about the number of tests run

Status: RESOLVED FIXED

(Testing :: Mochitest, defect)

Description

[Dão Gottwald [:dao]]

Attachment: patch

STR:

1. Create this browser chrome test:
function test() {
  ok(true, 1);
}
2. Run it.

Expected Result:
> Browser Chrome Test Summary
>	Passed: 1

Actual Result:
> Browser Chrome Test Summary
>	Passed: 4

Comment 1

[Dão Gottwald [:dao]]

http://hg.mozilla.org/mozilla-central/rev/804ddd711e76

Comment 2

[Neil Deakin]

This change has made the waitForFocus output to not appear in the log, making it difficult to investigate focus issues in tests.

Comment 3

[Dão Gottwald [:dao]]

Last I checked it did show up in browser chrome test logs. Apparently TEST-INFO is also commonly used in other test suites according to MXR, so this should be working in theory.

Comment 4

[Dão Gottwald [:dao]]

Maybe you're referring to a log different from tinderbox output?

Comment 5

[Neil Deakin]

Looks like only the browser-chrome tests have this issue.

For example, a recent log: http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1281973136.1281973882.23070.gz&fulltext=1

Comment 6

[Dão Gottwald [:dao]]

Yeah. I'll double-check if I see it locally with browser chrome tests.

Comment 7

[Dão Gottwald [:dao]]

Attachment: follow-up fix for browser chrome tests

There's no parentrunner for browser chrome tests, so SimpleTest._logEnabled is undefined. As far as I can see, the original SimpleTest.ok calls worked because browser-test.js overwrites this and similar SimpleTest methods with its own versions.

Comment 8

[Dão Gottwald [:dao]]

http://hg.mozilla.org/mozilla-central/rev/51e296a1db95