Closed Bug 584995 Opened 9 years ago Closed 9 years ago

waitForFocus makes test analysis lie about the number of tests run

Categories

(Testing :: Mochitest, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
mozilla2.0b4

People

(Reporter: dao, Assigned: dao)

Details

Attachments

(2 files)

Attached patch patchSplinter Review
STR:

1. Create this browser chrome test:
function test() {
  ok(true, 1);
}
2. Run it.

Expected Result:
> Browser Chrome Test Summary
>	Passed: 1

Actual Result:
> Browser Chrome Test Summary
>	Passed: 4
Attachment #463484 - Flags: review?(enndeakin)
Attachment #463484 - Flags: review?(enndeakin) → review+
http://hg.mozilla.org/mozilla-central/rev/804ddd711e76
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla2.0b4
This change has made the waitForFocus output to not appear in the log, making it difficult to investigate focus issues in tests.
Last I checked it did show up in browser chrome test logs. Apparently TEST-INFO is also commonly used in other test suites according to MXR, so this should be working in theory.
Maybe you're referring to a log different from tinderbox output?
Looks like only the browser-chrome tests have this issue.

For example, a recent log: http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1281973136.1281973882.23070.gz&fulltext=1
Yeah. I'll double-check if I see it locally with browser chrome tests.
There's no parentrunner for browser chrome tests, so SimpleTest._logEnabled is undefined. As far as I can see, the original SimpleTest.ok calls worked because browser-test.js overwrites this and similar SimpleTest methods with its own versions.
Attachment #466377 - Flags: review?(enndeakin)
Attachment #466377 - Flags: review?(enndeakin) → review+
You need to log in before you can comment on or make changes to this bug.