585021 - No tab animation when opening the Home page in a new tab

Status: VERIFIED FIXED

(Firefox :: Tabbed Browser, defect)

Description

[Thomas Goldstein]

User-Agent:       Mozilla/5.0 (Windows NT 5.1; rv:2.0b4pre) Gecko/20100805 Minefield/4.0b4pre
Build Identifier: Mozilla/5.0 (Windows NT 5.1; rv:2.0b4pre) Gecko/20100805 Minefield/4.0b4pre

Whenever I open a new tab, I see the new smooth tab animation. Except when I middle click (or Ctrl + click) the Home button, in which case the tab appears instantaneously, with no animation (ie: the old way).
I would expect the tab creation animation in all cases.

Reproducible: Always

Comment 1

[Tiago Sá]

Since the home button is going to disappear (and, hopefully, the home pages will be accessed from inside the home tab, as links in widget or something), I think this is a WONTFIX.

Comment 2

[Please Ignore This Troll (Account Disabled)]

actually I'm going to hide home tab when it will appear, since I don't like the idea of having some tab constantly on the tab bar, eating free space, even when it's not needed.
And I think many users will agree with me - the idea of adding home tab - contradicts with the idea of space economy. But since the decision about the implementation of that case is already taken, all I can - just write a userstyle to hide it. But I will use the "open homepage" button.
And you Tiago, offering the community to ignore the interests of such people like me?

Comment 3

[Tiago Sá]

I don't think it will be possible to keep the home button working as it is now. Or erasing the home tab. The home tab is intended to have interface that is only available there, so I don't think your plan is going to work out quite as you are expecting it too, drug0y. Of course, your point is valid, but it's something that needs to be addressed in the new design (I've talked about it at mozilla.dev.usability already, and I've shown my stance on the matter), rather than something that will prevent the new design from going forwards.

So, going a bit offtopic, the way I believe it's going to work is this: the current home button is going to disappear, and it's going to give way to the home tab, a local about:home page (not a custom hope page) with a search field and more interface (like session manager, firefox help, feedback and whatnot). Inside that home tab, I believe there will be a widget to open your startup pages (or whatever they're going to be called). It hasn't been decided if those startup pages will be opened, by default, as App Tabs, but I believe they shouldn't. Of course, startup pages will be opened at startup (if configured to be), as usual, but as normal tabs, and not in the home tab (since the home tab is for the about:home - and it's only one tab - and home pages may be multiple, and the home tab is supposed to include interface that is not available elsewhere).

It is a change, and has been decided upon, but it's not mean to disrupt the workflow of the users: rather, it's meant to improve it and speed it up, while, certainly, altering it a bit. It is a big new concept, a big improvement in browser design and a big innovation, and it's particularly great to see that it won't break the browser for people. So you can lay your fears to rest, I believe.

Back on topic: I think this is a WONTFIX.

Comment 4

[imradyurrad]

This can't be wontfix seeing as how it's the only aspect of the browser where the animation doesn't work.

We're not discussing the home tab or how it's supposed to work. Until the home button's removed, this is a valid bug.

Comment 5

[Thomas Goldstein]

As of now, I'm not worried about the fact the Home button doesn't trigger the new tab animation if the Home button is about to be removed. However, I'm concerned by the fact there is a code path in Firefox that allows the user to open a new tab without triggering the creation animation, ie: not all the tab creations the user triggers go through the same code "pipe".

In other words, I'm concerned about the underlying issue which might show up again later, for other things than the Home button. Just highlighting the fact that even though the Home button will be removed, that doesn't mean there is nothing to fix here.
I could be wrong, though, as I didn't look at the code; it's possible that removing the Home button code will patch that particular hole for good.

Comment 6

[Please Ignore This Troll (Account Disabled)]

(In reply to comment #3)
1. As it was already said - currently there is no home tab, so the bug is valid.
2. I hope mozdevs are not going to completely remove home button, because usually they follow another kind of policy: add new features without cutting the old ones, if possible. Not a single roadmap it was said they going to cut home button.
What concerns the home tab - I'm a little bit worried about it, since I don't really get the idea of it, it seems quite useless for me and even harmful (i'm worried about space economy, especially on the tabbar, cause I usually surf 50+ opened tabs style).
You said home tab is not going to be just a regular homepage, it should hook the search engines and maybe even some "widgets" (what the hell is it? I mean, how it gonna look like and what they can?). But what is the problem now to make a custom homepage? Add as much bookmarks, searchbars and "widgets" to it.
Why move the homepage button from current place (which can be customized) to the tabbar: without an ability to move it from there + remove the old homepage button? I don't get it, and it is a little bit offtopic here.

Comment 7

[Tiago Sá]

If you're worried about space economy, no offense, but just wait until you see them putting tabs on title bar when maximized. Then complain about space economy.

The home tab, or rather, the about:home page, is going to be, in Firefox 4, a simple local homepage that mimicks, for the most part, the current default home page. That's the plan. For more info, check the appropriate bugs and wiki pages.

Comment 8

[Dão Gottwald [:dao]]

(In reply to comment #6)
> 1. As it was already said - currently there is no home tab, so the bug is
> valid.

Yeah. The discussion about the home tab is off topic here, please stop it.

Comment 9

[Dão Gottwald [:dao]]

Attachment: patch

Comment 10

[Dão Gottwald [:dao]]

http://hg.mozilla.org/mozilla-central/rev/8d69655afd51

Comment 11

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Verified fixed with Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:2.0b4pre) Gecko/20100813 Minefield/4.0b4pre