If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Vector: "dead" code not dead yet

RESOLVED FIXED

Status

Tamarin
Library
RESOLVED FIXED
7 years ago
7 years ago

People

(Reporter: pnkfelix, Unassigned)

Tracking

Details

Attachments

(1 attachment)

tamarin-redux changeset:   4975:ef2e1e6b152d #ifdef'ed out some Vector code that is referenced by the Player.

Short term: To fix the build, We need to put the code back.
(Longer term: perhaps add tests of the code's functionality?)
(Reporter)

Updated

7 years ago
See Also: → bug 584318
Created attachment 463535 [details] [diff] [review]
removed #ifdef 0's.

I was able to do a Standalone build with this changeset; I did not have to turn the "private:" back into "protected:" (something Lars had warned me I might need to do).
Attachment #463535 - Flags: review?(lhansen)

Updated

7 years ago
Attachment #463535 - Flags: review?(lhansen) → review+
(push please)
Fix pushed to TR in changeset 4980, http://hg.mozilla.org/tamarin-redux/rev/7e3bb5dc13e1
Fix pushed to TR in changeset 4980, http://hg.mozilla.org/tamarin-redux/rev/7e3bb5dc13e1
Status: NEW → RESOLVED
Last Resolved: 7 years ago
OS: Mac OS X → Windows 7
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.