Closed
Bug 585026
Opened 14 years ago
Closed 14 years ago
Vector: "dead" code not dead yet
Categories
(Tamarin Graveyard :: Library, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: pnkfelix, Unassigned)
References
Details
Attachments
(1 file)
|
1.85 KB,
patch
|
lhansen
:
review+
|
Details | Diff | Splinter Review |
tamarin-redux changeset: 4975:ef2e1e6b152d #ifdef'ed out some Vector code that is referenced by the Player. Short term: To fix the build, We need to put the code back. (Longer term: perhaps add tests of the code's functionality?)
|
Reporter | |
Comment 1•14 years ago
|
||
I was able to do a Standalone build with this changeset; I did not have to turn the "private:" back into "protected:" (something Lars had warned me I might need to do).
Attachment #463535 -
Flags: review?(lhansen)
|
||
Updated•14 years ago
|
Attachment #463535 -
Flags: review?(lhansen) → review+
|
|
Reporter | |
Comment 2•14 years ago
|
||
(push please)
|
|
Reporter | |
Comment 3•14 years ago
|
||
Fix pushed to TR in changeset 4980, http://hg.mozilla.org/tamarin-redux/rev/7e3bb5dc13e1
|
|
Reporter | |
Comment 4•14 years ago
|
||
Fix pushed to TR in changeset 4980, http://hg.mozilla.org/tamarin-redux/rev/7e3bb5dc13e1
Status: NEW → RESOLVED
Closed: 14 years ago
OS: Mac OS X → Windows 7
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•