585080 - Clicking on mailto: URI crashes the content process

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Matt Brubeck (:mbrubeck)]

On Android, load any page with a mailto: link, e.g. http://bugzil.la/12345 and click the mailto: link.  The content process crashes.

Comment 1

[Aakash Desai [:aakashd]]

This works for me on build:
Mozilla/5.0 (Android; U; Linux armv71; en-US; rv:2.0b4pre) Gecko/20100811 Namoroka/4.0b4pre Fennec/2.0a1pre

Comment 2

[Matt Brubeck (:mbrubeck)]

I can still reproduce this on the same nightly Android build (20100811).

Comment 3

[Brad Lassey [:blassey] (use needinfo?)]

Attachment: patch

the crash you're seeing is due to use trying to use the bridge from the content process, this patch fixes that.

Unfortunately I see another crash that happens after this that I haven't been able to figure out. With this patch you can launch the picker and the helper app, but then some time later (several seconds to a minute or two later) the browser will crash. I think we should take this patch as it is a better experience and file another bug for that second crash.

Comment 4

[Michael Wu [:mwu]]

Comment on attachment 464897 [details] [diff] [review]
patch

Looks ok. Just a bunch of formatting nits that should be fixed.

> already_AddRefed<nsIMIMEInfo>
> nsMIMEInfoAndroid::GetMimeInfoForMimeType(const nsACString& aMimeType)
> {
>   mozilla::AndroidBridge* bridge = mozilla::AndroidBridge::Bridge();
>+    if (!bridge) 
>+    {
>+      // we don't have access to the bridge, so just assume we can handle 
>+      // the protocol for now and let the system deal with it
>+      return new nsMIMEInfoAndroid(aMimeType);
>+    }
>+  
Wrong indentation level. { should be on the same line as the if.

>@@ -91,6 +101,9 @@ nsMIMEInfoAndroid::GetMimeInfoForMimeTyp
> already_AddRefed<nsIMIMEInfo>
> nsMIMEInfoAndroid::GetMimeInfoForFileExt(const nsACString& aFileExt)
> {
>+  
>+  if (!mozilla::AndroidBridge::Bridge())
>+    return nsnull;
Remove the extra space at the top.

>@@ -102,12 +115,22 @@ nsMIMEInfoAndroid::GetMimeInfoForProtoco
>                                           PRBool *found,
>                                           nsIHandlerInfo **info)
> {
>+    const nsString &empty = EmptyString();
>+    const nsCString &emptyC = EmptyCString();
>     mozilla::AndroidBridge* bridge = mozilla::AndroidBridge::Bridge();
>+    if (!bridge) 
>+    {
>+      // we don't have access to the bridge, so just assume we can handle 
>+      // the protocol for now and let the system deal with it
>+      *found = PR_TRUE;
>+      *info = new nsMIMEInfoAndroid(emptyC);       
>+      return NS_OK;
>+    }
>+      
>+
{ should be on the same line as if. Indentation is inconsistent.

Comment 5

[Brad Lassey [:blassey] (use needinfo?)]

Attachment: patch

Did a white space clean up for the whole file. Carrying the review.

Comment 6

[Michael Wu [:mwu]]

http://hg.mozilla.org/mozilla-central/rev/de9594c50aa9

Comment 7

[Catalin Suciu [:csuciu]]

Verified fixed on:
Mozilla/5.0 (Android;Linux armv7l;rv:9.0a1)Gecko/20110919
Firefox/9.0a1 Fennec/9.0a1
Device: HTC Desire
OS: Android 2.2