Bring solaris deep phase build slave back online

VERIFIED FIXED

Status

defect
VERIFIED FIXED
9 years ago
8 years ago

People

(Reporter: brbaker, Assigned: brbaker)

Tracking

unspecified
Sun
Solaris
Bug Flags:
flashplayer-triage +

Details

(Whiteboard: buildbot)

Attachments

(1 attachment)

Assignee

Description

9 years ago
The solaris deep phase build slave has been offline for some time now. The machine has been updated to run python 2.6 and should be ready to bring back online.

I have been running through the build steps manually and one issue that I have found is that the "test_generic" build step uses the default timeout of 1200 seconds, but I have noticed that some of the tests that are run in a "deep" config are taking 1300+ seconds to run, meaning that buildbot will time these out. Will need to update the "test_generic" build step to take an optional timeout value.
Flags: flashplayer-triage+
Assignee

Comment 1

9 years ago
add an optional param to test_generic build step, default the value to 1200 (previous default)

pass --showtimes to the solaris deep test passes and bump the timeout to 2400
Attachment #463571 - Flags: review?(cpeyer)

Updated

9 years ago
Attachment #463571 - Flags: review?(cpeyer) → review+
Assignee

Comment 2

9 years ago
Comment on attachment 463571 [details] [diff] [review]
add a timeout param to test_generic

patch pushed as 4987:293346e6b248
Assignee

Updated

9 years ago
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Assignee

Comment 3

9 years ago
follow-up to change 4987 (4990:e11f1a751fcc), timeout needs to be a number, not a string. This was causing the acceptance runs in buildbot to fail.
Assignee

Updated

8 years ago
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.