585108 - We don't need unit test builders for "mozilla-central" and "mozilla-2.0" releases except for win32

Status: RESOLVED FIXED

(Release Engineering :: General, defect, P2)

Description

[Armen [:armenzg]]

Attachment: disable unit tests on releases for "mozilla-central" and "mozilla-2.0"

For Beta 3 I noticed that we are still running unit tests on the builders when we should not.
This brings confusion to whoever is doing the releases if they don't notice that they should be watching the runs on the minis rather than on the builders.

We did this switch on bug 570816.

Comment 1

[Rail Aliiev [:rail]]

Comment on attachment 463593 [details] [diff] [review]
disable unit tests on releases for "mozilla-central" and "mozilla-2.0"

Looks good. Could you also update mozilla2-staging release configs?

Comment 2

[Armen [:armenzg]]

Comment on attachment 463593 [details] [diff] [review]
disable unit tests on releases for "mozilla-central" and "mozilla-2.0"

http://hg.mozilla.org/build/buildbot-configs/rev/901d79d2447b

Added changes for staging.

pm reconfigured.

Comment 3

[Armen [:armenzg]]

As I just noticed, we should still run the unit tests on the builders.
I will provide another patch once I have it working.

Comment 4

[Armen [:armenzg]]

Attachment: we still run unit tests on the builders for win32

I switched to use [] instead of ().

Comment 5

[Armen [:armenzg]]

Attachment: we still run unit tests on the builders for win32

correct patch.

Comment 6

[Rail Aliiev [:rail]]

Comment on attachment 464555 [details] [diff] [review]
we still run unit tests on the builders for win32

A nit. Use ('win32',) instead of ['win32'] to be consistent with the previous type (tuple).

Comment 7

[Armen [:armenzg]]

Comment on attachment 464555 [details] [diff] [review]
we still run unit tests on the builders for win32

http://hg.mozilla.org/build/buildbot-configs/rev/fbb1ffc3f583

Nit taken.

production-master reconfigured.

Comment 8

[Lukas Blakk [:lsblakk] use ?needinfo]

So this is currently still turned on for 4.0b4 as per http://hg.mozilla.org/build/buildbot-configs/file/55218bd97eef/mozilla2/release-firefox-mozilla-2.0.py -- not sure if there's a new bug tracking turning it off again or not.

Comment 9

[[e-mail] (:bhearsum)]

(In reply to comment #8)
> So this is currently still turned on for 4.0b4 as per
> http://hg.mozilla.org/build/buildbot-configs/file/55218bd97eef/mozilla2/release-firefox-mozilla-2.0.py
> -- not sure if there's a new bug tracking turning it off again or not.

That file shows only win32 in unittestPlatforms, which is what this bug wants:
unittestPlatforms  = ('win32',)

Comment 10

[Armen [:armenzg]]

This is correct as Ben indicates.