If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Sort incoming batch requests by item ID before insert

RESOLVED FIXED

Status

Cloud Services
Server: Sync
RESOLVED FIXED
7 years ago
7 years ago

People

(Reporter: telliott, Assigned: telliott)

Tracking

({push-needed})

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

7 years ago
Tim thinks that deadlocking may be cause by batch inserting records in non-primary-key order. 

We'll sort before we do batch inserts, but it would be a good idea to do this on the client to. We also need to remember to support by collection *and* ID once we support multiple-collections functions (which we don't currently)
(Assignee)

Comment 1

7 years ago
Created attachment 463642 [details] [diff] [review]
Sorts incoming items by their id and id key parameters by id
Attachment #463642 - Flags: review?(tarek)
Attachment #463642 - Flags: review?(tarek) → review+
(Assignee)

Comment 2

7 years ago
Fixed in http://hg.mozilla.org/services/sync-server/rev/06e6c6fbfeab

Will not make Monday's push, obviously.
Status: NEW → RESOLVED
Last Resolved: 7 years ago
Keywords: push-needed
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.