585147 - Remove the title on Sites

Status: VERIFIED FIXED

(Input :: General, defect, P2)

Description

[Aakash Desai [:aakashd]]

"Input Dashboard - Sites" is a bit redundant as it's underneath the Input dashboard header. I'd prefer the title be removed altogether to save space.

Comment 1

[Michael Kurze [:michaelk]]

Should be fixed by patch 

http://github.com/michaelku/reporter/commit/27f48431a0d3f6c81a551c6ffa1cd2f879d7ca71

along with bug 585147

Comment 2

[Fred Wenzel [:wenzel]]

http://github.com/fwenzel/reporter/commit/85e9725

Comment 3

[Stephen Donner [:stephend] Not actively reading bugmail]

Still visible on http://input.stage.mozilla.com/en-US/sites.

Comment 4

[Michael Kurze [:michaelk]]

Hmmm, confused.  I cannot see it. Sure you cleared your cache?
What about production? If it's there, could you attach a screenshot indicating it? Maybe I am missing it somewhere else. Thanks!

Comment 5

[Stephen Donner [:stephend] Not actively reading bugmail]

(In reply to comment #4)
> Hmmm, confused.  I cannot see it. Sure you cleared your cache?
> What about production? If it's there, could you attach a screenshot indicating
> it? Maybe I am missing it somewhere else. Thanks!

It's in the page <title> -- thought that was to what comment 0 was referring:

 <title>Input Dashboard - Sites &mdash; Firefox Input</title>

I see it on both prod/staging; was it something else?  If it's not that, it's not clear from any of the comments where on the page it is.

Comment 6

[Michael Kurze [:michaelk]]

Ah, okay, there was an additional headline between menu and content that I removed. The wording in the bug report implies that it's about the window title, though.

Aakash, what about the window title, should we change that in some way?

Comment 7

[Aakash Desai [:aakashd]]

Yep, it should be "Sites - Firefox Input"

Comment 8

[Michael Kurze [:michaelk]]

Should be fixed as of this commit:

http://github.com/fwenzel/reporter/commit/bb7f9ffb218a26660c191d7b5b4a2bfda7475087

Comment 9

[Stephen Donner [:stephend] Not actively reading bugmail]

(In reply to comment #8)
> Should be fixed as of this commit:
> 
> http://github.com/fwenzel/reporter/commit/bb7f9ffb218a26660c191d7b5b4a2bfda7475087

1. Does this need to be committed/merged to master, or something?  Not seeing this on staging.
2. Why is this assigned to me, a lowly QA engineer? :-)

Comment 10

[Michael Kurze [:michaelk]]

1. AFAIK It should just appear on staging without further ado, I'll check with wenzel if I missed something.

2. Just for re-test. I assign it to me for now until I know why it has not got updated.

Comment 11

[Michael Kurze [:michaelk]]

Okay, the reason is probably, that sites had already been branched to ux-overhaul before my patch landed. I leave this bug open and assigned to me and I'll make sure that this string change finds its way in.

Comment 12

[Fred Wenzel [:wenzel]]

Yea, it's fixed now. Staging had trouble auto-updating itself last week.

Comment 13

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED on http://input.stage.mozilla.com/en-US/sites; thanks, Michael/Fred!

Comment 14

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/activity-stream/pull/5346