Status

()

RESOLVED FIXED
8 years ago
27 days ago

People

(Reporter: philikon, Assigned: philikon)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

test_bookmark_tracker and test_history_tracker are failing on mozilla-central.
Created attachment 463680 [details] [diff] [review]
v1
Assignee: nobody → philipp
Attachment #463680 - Flags: review?(mconnor)
(Assignee)

Updated

8 years ago
Attachment #463680 - Attachment is patch: true
Attachment #463680 - Attachment mime type: application/octet-stream → text/plain
Created attachment 463687 [details] [diff] [review]
nits

Also fix style nit: Use object, not array for associative array.
Attachment #463687 - Flags: review?(mconnor)
(Assignee)

Updated

8 years ago
Blocks: 584481
Comment on attachment 463687 [details] [diff] [review]
nits

Cancelling review, I'm going to address these nits as part of bug 583852 since that touches that part of the history store anyway.
Attachment #463687 - Flags: review?(mconnor)

Updated

8 years ago
Attachment #463680 - Flags: review?(mconnor) → review+
http://hg.mozilla.org/services/fx-sync/rev/d8f285f45d56
Status: NEW → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
Component: Firefox Sync: Backend → Sync
Product: Cloud Services → Firefox
You need to log in before you can comment on or make changes to this bug.