Closed Bug 585195 Opened 12 years ago Closed 12 years ago

Theme the Web Console filter bar appropriately on Windows

Categories

(Firefox :: Theme, defect)

All
Windows 7
defect
Not set
trivial

Tracking

()

RESOLVED FIXED
Tracking Status
blocking2.0 --- -

People

(Reporter: pcwalton, Assigned: pcwalton)

References

Details

(Keywords: uiwanted, Whiteboard: [kd4b6] [patchclean:0908])

Attachments

(2 files, 3 obsolete files)

Attached patch Proposed patch. (obsolete) — Splinter Review
It would be nice if the Web Console filter bar looked like a native platform filter bar on Windows. The attached patch does this. It's based on the filter bars in Thunderbird (cf. comm-central/mail/themes/qute/mail/quickFilterBar.css).
Attachment #463672 - Flags: feedback?(ddahl)
Can you post a screenshot?
Comment on attachment 463672 [details] [diff] [review]
Proposed patch.

+ with screenshot
Attachment #463672 - Flags: feedback?(ddahl) → feedback+
Attachment #463672 - Flags: review?(dietrich)
Patch rebased to trunk.
Attachment #465068 - Flags: review?(dietrich)
Comment on attachment 463672 [details] [diff] [review]
Proposed patch.

Canceling review on this one because it no longer applies.
Attachment #463672 - Flags: review?(dietrich)
Can you attach a screenshot, per comment #2?
Attached image Screenshot. (obsolete) —
Screenshot attached.
Comment on attachment 465068 [details] [diff] [review]
Proposed patch (trunk rebase 2010-08-11).

thanks, looks great. r=me.
Attachment #465068 - Flags: review?(dietrich) → review+
Comment on attachment 465068 [details] [diff] [review]
Proposed patch (trunk rebase 2010-08-11).

can we get some approval for this?
Attachment #465068 - Flags: approval2.0?
Attachment #465068 - Flags: approval2.0? → approval2.0+
Comment on attachment 465068 [details] [diff] [review]
Proposed patch (trunk rebase 2010-08-11).

http://hg.mozilla.org/mozilla-central/rev/e751acb410d0
Attachment #465068 - Attachment description: Proposed patch (trunk rebase 2010-08-11). → [checked-in] Proposed patch (trunk rebase 2010-08-11).
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
This was backed out in revision da59cce7bfa2.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Keywords: checkin-needed
Component: Developer Tools → Theme
QA Contact: developer.tools → theme
Comment on attachment 465068 [details] [diff] [review]
Proposed patch (trunk rebase 2010-08-11).

>+    background: -moz-linear-gradient(top, #f2f7fd 0, #e9f2fc 12px, #e3eefb 12px, #e3eefb 100%);

This is going to look entirely inappropriate on XP, isn't it?
Attachment #465068 - Flags: review-
Attachment #465068 - Attachment description: [checked-in] Proposed patch (trunk rebase 2010-08-11). → Proposed patch (trunk rebase 2010-08-11).
Keywords: checkin-needed
Attachment #463672 - Attachment is obsolete: true
(In reply to comment #11)
> Comment on attachment 465068 [details] [diff] [review]
> Proposed patch (trunk rebase 2010-08-11).
> 
> >+    background: -moz-linear-gradient(top, #f2f7fd 0, #e9f2fc 12px, #e3eefb 12px, #e3eefb 100%);
> 
> This is going to look entirely inappropriate on XP, isn't it?

Sounds like it will. How do we handle the case of a style for XP and a style for vista/7?
Before we get into the implementation details, could somebody please point me to a native filter bar example? Thunderbird isn't the best role model for a native app.

I don't quite like how this seemingly tries to integrate with the primary toolbars -- it fails halfway, because of the border and because the gradient starts anew. We wouldn't even want it to integrate seamlessly, since the filter bar belongs to content below it rather than the toolbars above it. So just using -moz-appearance: none; background-color: -moz-dialog; for a clean cut might be better.
(In reply to comment #13)
> Before we get into the implementation details, could somebody please point me
> to a native filter bar example? Thunderbird isn't the best role model for a
> native app.

No idea where to point you:)

> 
> I don't quite like how this seemingly tries to integrate with the primary
> toolbars -- it fails halfway, because of the border and because the gradient
> starts anew. We wouldn't even want it to integrate seamlessly, since the filter
> bar belongs to content below it rather than the toolbars above it. So just
> using -moz-appearance: none; background-color: -moz-dialog; for a clean cut
> might be better.

Sounds like a simpler, better approach.
Keywords: uiwanted
Whiteboard: [kd4b6] [patchclean:0817]
Whiteboard: [kd4b6] [patchclean:0817] → [kd4b6] [patchbitrot]
This should be a blocker, because we want the console to look right on Windows.
Severity: normal → blocker
blocking2.0: --- → ?
(In reply to comment #15)
> This should be a blocker, because we want the console to look right on Windows.

Bug severity is different from release blocking status.
Severity: blocker → trivial
Blocks: devtools4b7
not going to hold the release for thematic polish on developer-focused non-primary UI, blocking-.

earlier patch already has approval. if new changes are ready, carry it over.
blocking2.0: ? → -
New patch address Dao's comments and uses -moz-dialog.
Attachment #465068 - Attachment is obsolete: true
Attachment #473098 - Flags: review?(dietrich)
Attachment #473098 - Flags: feedback?(dao)
Attached image Screenshot, version 2.
New screenshot posted.
Attachment #465369 - Attachment is obsolete: true
Comment on attachment 473098 [details] [diff] [review]
[checked-in] Proposed patch, version 2.

dao's review here is more appropriate, and enough.
Attachment #473098 - Flags: review?(dietrich)
Attachment #473098 - Flags: feedback?(dao) → review?(dao)
(In reply to comment #20)
> Comment on attachment 473098 [details] [diff] [review]
> Proposed patch, version 2.
> 
> dao's review here is more appropriate, and enough.

Okay, switched r? to him.
Whiteboard: [kd4b6] [patchbitrot] → [kd4b6] [patchclean:0908]
Attachment #473098 - Flags: review?(dao) → review+
Comment on attachment 473098 [details] [diff] [review]
[checked-in] Proposed patch, version 2.

Requesting approval for this simple patch that is an important visual improvement on Windows.
Attachment #473098 - Flags: approval2.0?
Attachment #473098 - Flags: approval2.0? → approval2.0+
Keywords: checkin-needed
Comment on attachment 473098 [details] [diff] [review]
[checked-in] Proposed patch, version 2.

http://hg.mozilla.org/mozilla-central/rev/0425b1e11d2d
Attachment #473098 - Attachment description: Proposed patch, version 2. → [checked-in] Proposed patch, version 2.
Status: REOPENED → RESOLVED
Closed: 12 years ago12 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.