585202 - performance runtests.py: running a test with no results will cause an exception

Status: VERIFIED FIXED

(Tamarin Graveyard :: Tools, defect)

Description

[Chris Peyer]

If a test is run that compiles but does not output any results, the harness will throw:

Runtest Abnormal Exit
Traceback (most recent call last):
  File "./runtests.py", line 944, in <module>
    runtest = PerformanceRuntest()
  File "./runtests.py", line 133, in __init__
    RuntestBase.__init__(self)
  File "../util/runtestBase.py", line 187, in __init__
    self.run()
  File "./runtests.py", line 152, in run
    self.runTests(self.tests)
  File "./runtests.py", line 419, in runTests
    o = self.runTest((t, testnum))
  File "./runtests.py", line 714, in runTest
    if len(resultsDict1[resultsDict1.keys()[0]]) != self.iterations:
IndexError: list index out of range

This is due to the fact that resultsDict1 will be empty and so the keys list will be an empty list.

Comment 1

[Chris Peyer]

Attachment: Make sure perf tests return metrics

Comment 2

[Chris Peyer]

Pushed to redux:

http://hg.mozilla.org/tamarin-redux/rev/b8ff544aee67